On 11/09/2010 06:01 PM, Anca Luca wrote:
> Hi Marius,
>
> On 11/09/2010 07:36 AM, Marius Dumitru Florea wrote:
>> On 11/08/2010 06:45 PM, Vincent Massol wrote:
>>>
>>> On Nov 8, 2010, at 5:38 PM, Jerome Velociter wrote:
>>>
>>>> On Mon, Nov 8, 2010 at 5:17 PM, Vincent Massol<[email protected]>
>>>> wrote:
>>>>>
>>>>> On Nov 8, 2010, at 4:47 PM, Jerome Velociter wrote:
>>>>>
>>>>>> On Mon, Nov 8, 2010 at 4:34 PM, Raluca Stavro<[email protected]>
>>>>>> wrote:
>>>>>>> Hello,
>>>>>>>
>>>>>>> I am working on http://jira.xwiki.org/jira/browse/XE-741 and I would
>>>>>>> need a final list of macro and parameter names. These would be the
>>>>>>> current namings:
>>>>>>>
>>>>>>> Macro name:
>>>>>>> * recentactivity
>>>>>>> -> to be replaced with 'activity'
>>>>>
>>>>> ok for me
>>>>>
>>>>>>> Parameter names:
>>>>>>> * 'showRss' (boolean: false by default) - Whether to show activity
>>>>>>> rss links or not.
>>>>>>> -> to be replaced with 'rss'
>>>>>
>>>>> ok for me
>>>>>
>>>>>>> * 'showMinor' (boolean: false by default): - Whether to show
>>>>>>> modifications that create minor versions or not.
>>>>>>> -> to be replaced with 'minor'
>>>>>
>>>>> ok for me
>>>>>
>>>>>>> * 'tag' (comma separated list): - Comma separated list of tags to
>>>>>>> display activity for.
>>>>>>> -> to be replaced with 'tags'
>>>>>
>>>>> ok for me. This is combined with the spaces parameter.
>>>>>
>>>>>>> * 'space' (comma separated list): - Comma separated list of spaces
>>>>>>> to display the recent activity for.
>>>>>>> -> to be replaced with 'spaces'
>>>>>
>>>>> ok for me
>>>>>
>>>>>>
>>>>>> Actually I've come to realize yesterday that this parameter is not
>>>>>> enough, I'd like to see a "scope" parameter in addition, to be able to
>>>>>> say
>>>>>> {{activity scope='space' /}} to have activity for just the current space
>>>>>
>>>>> I don't like too much when parameters override each others. That would
>>>>> mean that scope=space overrides the spaces parameter.
>>>>
>>>> I don't like it too much either, but IMHO the fact now it requires
>>>> scripting for a basic use case like that is even worse.
>>>> We would need to precise in the documentation the scope params take
>>>> over the spaces one, I think I could live with that.
>>>>
>>>>>
>>>>> What about displaying events for the current user only?
>>>>> What about displaying events for the current wiki only?
>>>>
>>>> Make sense as scopes.
>>>
>>> How do you specify: current wiki, current user? As a comma-separated list?
>>> If so then it should be "scopes" and not "scope".
>>
>> +1 for a "scopes" parameter which takes a comma separated list of
>> "references" like wiki:WikiName, space:SpaceName, doc:Space.Page,
>> user:UserName. This "references" could be link references but I don't
>> know if the rendering supports link reference schemes like "wiki",
>> "space" or "user" at the moment.
>
> I still don't see how this would help to display the current changes for
> the current space (therefore space scope but with 'current space'
> regardless of what's the current space) without velocity scripting (see
> Jerome's initial description of the issue). Could you provide an example?
Considering that references are resolved relative to the current wiki,
space, page then we could say that:
space: -> CurrentWiki:CurrentSpace
space:SpaceName -> CurrentWiki:SpaceName
space:WikiName:SpaceName -> WikiName:SpaceName
"user:" is a bit different but you could still say it represents the
current user. "group:" would be useful too to display the activity of a
specific user group.
Note that I haven't thought too much about the implementation. It's just
an idea that came to my mind when I read Jerome's comment.
>
>> It should be easy to add them though.
>> One problem would be to escape commas in these references since comma
>> separates the scopes.
>
> There already is the type "list of strings" for java macro parameters,
> whose syntax is a comma separated list of items, surrounded or not by
> {}. To be checked how the comma behaves for the such a java macro, it
> should be the same for wiki macros. And it will be all simpler when
> we'll have wiki macro parameters types.
Indeed.
Thanks,
Marius
>
> Thanks,
> Anca
>
>>
>> Hope this helps,
>> Marius
>>
>>>
>>> BTW we're missing a "wikis" parameter too.
>>>
>>> Thanks
>>> -Vincent
>>>
>>>> Jerome.
>>>>
>>>>>
>>>>>> This way not needing to wrap the activity macro in a velocity/script
>>>>>> call any longer, since it makes that feature not usable for a portion
>>>>>> of users that would have been able to use it otherwise.
>>>>>>
>>>>>> Sorry to come late with that.
>>>>>>
>>>>>> Jerome.
>>>>>>
>>>>>>> -> also remove 'recent' from the macro description
>>>>>>> * 'space' (comma separated list): - Comma separated list of spaces
>>>>>>> to display the recent activity for.
>>>>>>> -> to be replaced with 'spaces'
>>>>>>> -> also remove 'recent' from the macro description
>>>>>>> * 'author' (comma separated list): - Comma separated list of authors
>>>>>>> whose modifications to show.
>>>>>>> -> to be replaced with 'authors'
>>>>>
>>>>> ok for me
>>>>>
>>>>>>> * 'changesNb' (number: 30 by default): - Number of activity to show.
>>>>>>> -> to replace the description with 'Number of pages to display the
>>>>>>> activity of.'
>>>>>>> -> to be replaced with 'pages' or 'entries' or some other name that
>>>>>>> would fit better; you are welcome to add naming proposals.
>>>>>
>>>>> size, entries
>>>>>
>>>>>>> -> to replace '30' with '20', now that each entry (page) contains a
>>>>>>> number of sub-entries (activity events) and there will be a way to
>>>>>>> 'show more' entries (Facebook style)
>>>>>>>
>>>>>>> New macro parameters to be added:
>>>>>>> * 'events' (number: 10 by default): - Number of events to show for
>>>>>>> each page entry.
>>>>>>> -> you are welcome to add naming proposals.
>>>>>
>>>>> maxEvents ? I'm ok with events I think.
>>>>>
>>>>>>> * 'modifications' (boolean: false by default) - Whether to show 'see
>>>>>>> modifications' link on 'edited the page' events.
>>>>>>> -> other naming proposals: 'diff', 'differences', 'actions'
>>>>>
>>>>> Same param name as for the spaces macro. Did we agree on 'actions'? (I
>>>>> don't recall)
>>>>>
>>>>> Thanks
>>>>> -Vincent
>>>>>
>>>>>>>
>>>>>>> Raluca.
>>>>>>>
>>>>>>>
>>>>>>>> On Oct 20, 2010, at 4:05 PM, Anca Luca wrote:
>>>>>>>>
>>>>>>>>> Hi devs,
>>>>>>>>>
>>>>>>>>> I've been working on http://jira.xwiki.org/jira/browse/XE-721 and
>>>>>>>>> it's done on my local. This is the recent changes macro based on the
>>>>>>>>> current implementation (not the activity stream one), but the idea is
>>>>>>>>> that we'll rewrite it to display recent activity in the future. I
>>>>>>>>> will commit it for the moment, in the 2.6 trunk, as is, but I would
>>>>>>>>> like to discuss here the name of the macro and its parameters:
>>>>>>>>> Macro name:
>>>>>>>>> recentchanges, changes, activity, recentactivity
>>>>>>>> +1 for "activity" to be in line with the upcoming recent activity
>>>>>>>> feature
>>>>>>> planned for 2.6.
>>>>>>>>
>>>>>>>> No need for "recent", "activity" is enough. It's about the activity of
>>>>>>>> the wiki.
>>>>>>>>> Parameters:
>>>>>>>>> * rss link should be shown at the bottom of the changes table
>>>>>>>>> (boolean): showRss, rss
>>>>>>>> +1 rss (default true)
>>>>>>>>
>>>>>>>>> * minor changes are shown or not (boolean, default false): showMinor,
>>>>>>>>> minor
>>>>>>>> +1 minor
>>>>>>>>
>>>>>>>>> * shows "see modifications" link next to entries (boolean, default
>>>>>>>>> true): showDiff, showDifferences, diff, differences
>>>>>>>> I don't like too much diff*
>>>>>>>> What about "actions"? It's more than just the difference link, there
>>>>>>>> could be
>>>>>>> other actions, as in the {{spaces/}} macro for example.
>>>>>>>>> * number of changes to show (number, 0 means "all", defaults to 30):
>>>>>>>>> changesNb, changesCount, number, count, limit
>>>>>>>> +1 count
>>>>>>>>
>>>>>>>>> * tags of documents to show chages for (comma separated list): tag,
>>>>>>>>> tags
>>>>>>>> +1 tags
>>>>>>>>
>>>>>>>>> * spaces of documents to show changes for (comma separated list):
>>>>>>>>> space, spaces
>>>>>>>> +1 spaces
>>>>>>>>
>>>>>>>>> * authors of documents to show changes for (comma separated list):
>>>>>>>>> author, authors
>>>>>>>> +1 authors
>>>>>>>>
>>>>>>>> Note that the types cannot be enforced since it's a wiki macro, I put
>>>>>>>> them there just for orientation.
>>>>>>>> I'd go for activity rss minor diff count tags spaces authors .
>>>>>>>>
>>>>>>>> Thanks -Vincent
>>>>> _______________________________________________
>>>>> devs mailing list
>>>>> [email protected]
>>>>> http://lists.xwiki.org/mailman/listinfo/devs
>>>>>
>>>> _______________________________________________
>>>> devs mailing list
>>>> [email protected]
>>>> http://lists.xwiki.org/mailman/listinfo/devs
>>>
>>> _______________________________________________
>>> devs mailing list
>>> [email protected]
>>> http://lists.xwiki.org/mailman/listinfo/devs
>> _______________________________________________
>> devs mailing list
>> [email protected]
>> http://lists.xwiki.org/mailman/listinfo/devs
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
