And btw, I see there is a ie-6.css . Can't we organise the IE rules in a
better way? Can we move the IE6/7 specific rules from ie-all.css to
ie-6.css ? If not, can we have ie-all.css (common rules) and then
ie-X.css where X in [6,7,8] if needed.
Thanks,
Marius
On 11/17/2010 12:57 PM, Marius Dumitru Florea wrote:
> On 11/17/2010 11:53 AM, Ecaterina Moraru (Valica) wrote:
>> Marius please revert this commit because ie-all means IE6, IE7 and IE8.
>>
>
>> * hacks are supposed to go for the IE6, IE7 part, while the non-affected
>> property goes for IE8.
>
> Caty, * is not valid before CSS property name. I know IE ignores it but
> I need to parse the CSS and that * prevents me. We need to find another
> way (using proper CSS syntax) to write CSS rules for IE6/7 only.
>
> Thanks,
> Marius
>
> P.S.: I asked Raluca and Sergiu about the * hack before doing this
> commit. They seemed to agree that the * is useless in a IE dedicated
> stylesheet. I guess I haven't explained myself too well.
>
>>
>> for example:
>>
>> .xwikiintracontent legend {
>> margin: -5px 0 5px 0;
>> - *margin: 5px 0 10px -7px;
>> + margin: 5px 0 10px -7px;
>> }
>>
>> even if you made this clean - you supposed to delete the overridden margin
>> property, but all these properties are needed to display correctly.
>>
>> Thanks,
>> Caty
>>
>>
>> On Wed, Nov 17, 2010 at 09:52,
>> mflorea<[email protected]>wrote:
>>
>>> Author: mflorea
>>> Date: 2010-11-17 08:52:49 +0100 (Wed, 17 Nov 2010)
>>> New Revision: 32928
>>>
>>> Modified:
>>> platform/skins/trunk/colibri/src/main/resources/colibri/ie-all.css
>>> Log:
>>> XSCOLIBRI-251: ie-all.css uses color theme variables without importing the
>>> color theme template
>>> * Also removed useless * hack since it's a IE dedicated stylesheet.
>>>
>>>
>>> Modified:
>>> platform/skins/trunk/colibri/src/main/resources/colibri/ie-all.css
>>> ===================================================================
>>> --- platform/skins/trunk/colibri/src/main/resources/colibri/ie-all.css
>>> 2010-11-17 07:43:03 UTC (rev 32927)
>>> +++ platform/skins/trunk/colibri/src/main/resources/colibri/ie-all.css
>>> 2010-11-17 07:52:49 UTC (rev 32928)
>>> @@ -1,3 +1,4 @@
>>> +#template('colorThemeInit.vm')
>>> body {
>>> behavior: url("$xwiki.getSkinFile('/htc/csshover3.htc')");
>>> }
>>> @@ -7,7 +8,7 @@
>>> }
>>>
>>> #docextrapanes {
>>> - *display: inline-block;
>>> + display: inline-block;
>>> }
>>>
>>> .minwidth, .minwidthb, .minwidthc, .minwidthd {
>>> @@ -29,7 +30,7 @@
>>>
>>> .xwikiintracontent legend {
>>> margin: -5px 0 5px 0;
>>> - *margin: 5px 0 10px -7px;
>>> + margin: 5px 0 10px -7px;
>>> }
>>>
>>> #commentscontent #AddComment .commentcontainer label {
>>> @@ -37,7 +38,7 @@
>>> }
>>>
>>> input.button {
>>> - *padding: 0 0 1px;
>>> + padding: 0 0 1px;
>>> }
>>>
>>> fieldset.xwikimessage {
>>>
>>> _______________________________________________
>>> notifications mailing list
>>> [email protected]
>>> http://lists.xwiki.org/mailman/listinfo/notifications
>>>
>> _______________________________________________
>> devs mailing list
>> [email protected]
>> http://lists.xwiki.org/mailman/listinfo/devs
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
