On 11/28/2010 11:13 PM, Sergiu Dumitriu wrote: > On 11/28/2010 07:54 PM, Marius Dumitru Florea wrote: >> Hi Sergiu, >> >> I've fixed this issue locally by making the selector more specific: >> >> #body.main (instead of body.main) >> >> and >> >> * html #body.main (instead of * html body.main) >> >> I think this is better because all the rules in RichTextArea.css are >> suppose to be overwrites and putting !important everywhere is an >> overhead. I hope you agree. >
> Isn't RichTextArea.css supposed to be independent of XWiki? #body is > XWiki specific, so it won't always work outside XWiki. You're right, but it can't be fully independent of XWiki. Some of the rules we overwrite in RichTextArea.css are very specific. Take for instance the "hX span" selector which targets the way XWiki renders headings. Anyway, I'm going to rewrite the "#body" and ".main" selectors. > > Actually, the independence is already sacrificed by the use of the color > theme. Indeed. We could split RichTextArea.css in two: generic overwrites vs. XWiki specific overwrites but I don't think it brings much value. Thanks, Marius > > I looked around when determining what's the best thing to do, and I saw > that !important was already used in the same ruleset for setting the > background and text color. > > Anyway, I'm not that familiar with the WYSIWYG, so I'll leave the > decision to you, feel free to change it if you consider it's better. > >> On 11/28/2010 03:58 AM, sdumitriu (SVN) wrote: >>> Author: sdumitriu >>> Date: 2010-11-28 02:58:54 +0100 (Sun, 28 Nov 2010) >>> New Revision: 33164 >>> >>> Modified: >>> >>> platform/web/trunk/xwiki-gwt-wysiwyg-client/src/main/resources/org/xwiki/gwt/wysiwyg/public/stylesheets/RichTextArea.css >>> Log: >>> XWIKI-5736: Horizontal scrollbar always visible in the WYSIWYG editor on >>> small screens >>> Fixed. >>> >>> Modified: >>> platform/web/trunk/xwiki-gwt-wysiwyg-client/src/main/resources/org/xwiki/gwt/wysiwyg/public/stylesheets/RichTextArea.css >>> =================================================================== >>> --- >>> platform/web/trunk/xwiki-gwt-wysiwyg-client/src/main/resources/org/xwiki/gwt/wysiwyg/public/stylesheets/RichTextArea.css >>> 2010-11-28 01:47:54 UTC (rev 33163) >>> +++ >>> platform/web/trunk/xwiki-gwt-wysiwyg-client/src/main/resources/org/xwiki/gwt/wysiwyg/public/stylesheets/RichTextArea.css >>> 2010-11-28 01:58:54 UTC (rev 33164) >>> @@ -32,8 +32,8 @@ >>> float: left; >>> height: auto; >>> margin: 0; >>> - min-height: 100%; >>> - min-width: 100%; >>> + min-height: 100% !important; >>> + min-width: 100% !important; >>> overflow: visible; >>> padding: 0; >>> position: static; > > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
