Very +1 for having only one simple macro to achieve the style. In my view I prefer
{{office attachment="wiki30-wysiwyg.odp" style="xxx" /}}
Ludovic
Le 07/01/11 11:06, Guillaume Lerouge a écrit :
Hi Marius, looks good to me. Maybe you should add a "gallery" or a "slideshow" macro that automatically to encapsulate the current code: {{slideshow attachment="wiki30-wysiwyg.odp"/}} would be equal to: {{velocity}} $xwiki.ssx.use('OfficePresentationViewer')## $xwiki.jsx.use('OfficePresentationViewer')## {{/velocity}} (% class="gallery" %)((( {{office attachment="wiki30-wysiwyg.odp"/}} ))) WDYT? Guillaume On Thu, Jan 6, 2011 at 11:36, Anca Luca<[email protected]> wrote:On 01/06/2011 10:37 AM, Marius Dumitru Florea wrote:Hi devs, Currently when we import an office presentation the office importer module generates an image for each slide and inserts it into the wiki syntax: image:myPresentation-slide0.jpg ... image:myPresentation-slideN.jpg Some users have complained that: * when the presentation has many slides (e.g. 100) the page is heavy because all the slide images are requested at page load time. * there's no way to switch slides using an user friendly UI. See http://jira.xwiki.org/jira/browse/XWIKI-5785 . One simple way to fix this is to group the images and to add a class name to the group. Then it will be easy to integrate an image gallery that replaces the group (found by its class name). I made a simple image gallery to demonstrate this. Please checkhttp://incubator.myxwiki.org/xwiki/bin/view/Improvements/OfficePresentationViewer I like this approach, my +1. The class name used by the office importer module should be configurable and should have a default value (e.g. "gallery").I don't find this really needed at this point.The office viewer macro can then be changed to have an optional cssClass parameter.The way I implemented these cssClass params for container is to add a class value to the existing default class, instead of replacing it -> it allows default behaviour + customizations. I followed the implementation of box macro wrt this, so I would suggest this behaviour. However, I have a little bug with the current impl, on my machine which has non default, smaller fonts in FF. See: http://incubator.myxwiki.org/xwiki/bin/download/Improvements/OfficePresentationViewer/overlapping.png for a print screen, the presentation images are too low, overlapping the text under. Happy coding, AncaIt would be nice if the office importer/viewer would also use a default image gallery, i.e. request on demand the JavaScript code and the CSS for the default image gallery when the class name (e.g. cssClass parameter) is not specified. WDYT? Thanks, Marius _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
<<attachment: ludovic.vcf>>
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
