On Jan 11, 2011, at 3:50 PM, Sergiu Dumitriu wrote: > On 01/11/2011 12:14 PM, Vincent Massol wrote: >> Hi Anca, >> >> On Jan 10, 2011, at 6:42 PM, lucaa (SVN) wrote: >> >>> Author: lucaa >>> Date: 2011-01-10 18:42:29 +0100 (Mon, 10 Jan 2011) >>> New Revision: 33919 >>> >>> Modified: >>> platform/web/trunk/standard/pom.xml >>> Log: >>> XWIKI-5843: Columns layout for container macro should not use inline styles >>> * Excluded the columns.css from minification, since it contains velocity >>> code and cannot be minified properly >> >> Shouldn't this comment be placed in the pom.xml just above the exclude >> instead? >> >> Otherwise, how are we going to remember this in a few months? > > All those excluded files are excluded for this reason. There is such a > comment right before the first exclude, which doesn't appear in the diff > context.
ok I thought each had a specific reason for being excluded.... Thanks -Vincent > >> Thanks >> -Vincent >> >>> Modified: platform/web/trunk/standard/pom.xml >>> =================================================================== >>> --- platform/web/trunk/standard/pom.xml 2011-01-10 17:01:53 UTC (rev >>> 33918) >>> +++ platform/web/trunk/standard/pom.xml 2011-01-10 17:42:29 UTC (rev >>> 33919) >>> @@ -378,6 +378,7 @@ >>> <exclude>**/actionButtons.js</exclude> >>> <exclude>**/notification.css</exclude> >>> <exclude>**/usersandgroups.js</exclude> >>> +<exclude>**/columns.css</exclude> >>> </excludes> >>> </configuration> >>> </plugin> >> _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
