Hi Vincent, On 02/09/2011 07:47 PM, Vincent Massol wrote: > > On Feb 9, 2011, at 10:42 AM, lucaa (SVN) wrote: > >> Author: lucaa >> Date: 2011-02-09 10:42:42 +0100 (Wed, 09 Feb 2011) >> New Revision: 34581 >> >> Added: >> enterprise/trunk/wiki/src/main/resources/XWiki/GadgetClass.xml >> Modified: >> enterprise/trunk/wiki/src/main/resources/Main/Dashboard.xml >> Log: >> XE-828: Main.Dashboard dashboard must be updated to store its gadgets in >> objects >> * Refactored the Main.Dashboard to store the gadgets in objects >> >> >> Modified: enterprise/trunk/wiki/src/main/resources/Main/Dashboard.xml >> =================================================================== >> --- enterprise/trunk/wiki/src/main/resources/Main/Dashboard.xml >> 2011-02-09 09:38:29 UTC (rev 34580) >> +++ enterprise/trunk/wiki/src/main/resources/Main/Dashboard.xml >> 2011-02-09 09:42:42 UTC (rev 34581) >> @@ -11,8 +11,8 @@ > > [snip] > > Another option would be to have an Initializer component in the Dashboard > macro module which would listen to the application started event (note that > this event needs the DB to be ready we need to talk about doing this one > since we're in need of it) and would create the GadgetClass if it doesn't > already exist (or update it if it's missing some fields for example). > > This would allow to: > 1) remove the dependency this commit is creating with the default XE XAR > 2) removes the need for a gadget application > 3) make the dashboard macro work even when the default XE XAR is not > installed or if the user hasn't updated to the newest XAR > > Notes: > * Since we don't have the app started event coupled with the app ready, we > could FTM have the dashboard macro implement Initializable and perform the > init there. > * Maybe we can think of other pages that would be needed for the gadget > "feature" (for ex listing all dashboards available in the current wiki, etc). > In this case we would need a specific gadget appilcation in > platform/applications IMO. Note that even if we need this application we > still don't need to have a GadgetClass.xml file. > > WDYT?
Totally agree, it is mentioned, more or less cryptic, in one of the TODOs in the code. Thanks, Anca > > Thanks > -Vincent > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
