On Mar 28, 2011, at 3:22 PM, Luca Anca wrote:
> On Mon, 2011-03-28 at 14:02 +0200, Vincent Massol wrote:
>> On Mar 28, 2011, at 1:53 PM, Luca Anca wrote:
>>
>>> On Mon, 2011-03-28 at 11:59 +0200, Vincent Massol wrote:
>>>> Hi devs,
>>>>
>>>> I'd like to modify the Box macro in the following manner:
>>>>
>>>> * Deprecate the "title" parameter. I don't believe it's needed right now
>>>> (it's put below the image and before the content) since it can simply be
>>>> put in the content
>>>
>>> Image too can be put in the content, even positioned in all the ways.
>>> I'm not convinced that image makes more sense than title.
>>
>> Indeed you're right. Example:
>>
>> {{box}}
>> image:icon:tick text here
>> {{/box}}
>>
>>> I'm 0 but I'm still to develop a full opinion about this macro. FTM it
>>> feels it needs a bit of work to define the usecases (I mean besides our
>>> own macros that extend it), to see how it makes sense for the user. From
>>> my pov, not in this way (remove title and improve image support).
>>
>> Right now I'd be in favor of dropping also the image parameter (again not
>> talking about backward compat here).
>
> Then we drop box macro and add border and background color options to
> the container macro :),
We might not even need those params since they're already supported by using
block parameters...
(% style="..." %)(((
{{container}}
....
{{/container}}
)))
Note: that's before we add block param support for macros directly (shortcut):
(% style="..." %)
{{container}}
...
{{/container}}
> and make those configurable (they're not, for
> the box).
We need the wysiwyg editor to support adding block parameters.
> Since, as we said before, there's not such a big difference
> between box and container. I think there is a mail about this on the dev
> list.
Indeed, that's a good option: we deprecate the current Box macro completely
(100% backward compat preserved) and instead move to using the container macro.
It's just that for end users using a box macro is more obvious than using a
container macro IMO from a mnemotechnic POV.
Thanks
-Vincent
> Thanks,
> Anca
>
>>
>> Any use case where we'd need image or title params?
>>
>> Thanks
>> -Vincent
>>
>>> Thanks,
>>> Anca
>>>
>>>
>>>> * Add a new parameter for positioning the image with respect to the
>>>> content. Possible values would be: top (ie before the content) or left (ie
>>>> left of the content), possibly some others if we want (right)
>>>>
>>>> WDYT?
>>>>
>>>> Thanks
>>>> -Vincent
>>>>
>>>> PS: Note that one use case I have is to implement
>>>> http://jira.xwiki.org/jira/browse/XE-723 where I'd like the image to be
>>>> aligned with the text, left to it. I also find it a bit strange to be able
>>>> to add any wiki content to the title and I don't see the title as
>>>> necessary. Also right now if you have a title but no content the macro
>>>> doesn't work (content is mandatory).
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
