Thanks Marius for your advices. At the very beginning, I tried many ways to solves the critical problems which might encounter in the near future, so I implemented most of the features of auto-completion functions for wiki editors in a rough way. After the first commit, you gave me a lot of advices about the code style, and some suggestions about testing, so I decided to sepreate the current codes, and refine them in order to make it compliance with the convention of xwiki community. These days, I stripped the common module "Suggestion Box" for wiki editor and wysiwyg editor, refined them, commented on them and write some raw tests for them, then I made the last two commits, one commit is for "Link suggestion box" and the other one is for "Image suggestion box".
On Sat, Jun 25, 2011 at 11:36 PM, Marius Dumitru Florea < [email protected]> wrote: > Hi James, > > First of all, I hope you did well on your exams. > > On 06/25/2011 10:02 AM, 许凌志(Jamesxu) wrote: > > Hi, These days with the help of Marius, I seperate my codes into > > sub-modules, and commit them with their test modules one by one > > It's good that you started committing but I'm not happy with what I've > seen so far and more importantly I'm not happy with your way of working. > I see these issues: > > * you don't communicate enough about what you are doing > * you don't involve the community in the architecture/design decisions > * you tend to code in a depth-first style, meaning that you go too early > into unimportant details. You should layout the skeleton first and then > put flesh on it. > * you don't review your diff before committing > I want to say sorry for not reviewing my diff, I didn't realize that the codes there is such a mass, mix with the earlier commit which is not seperated and refined until receiving your review comments. I will try to solve this problem. > > In order to fix this I would like to establish some rules: > > (1) At the beginning of each week (Monday) you send a mail to this > mailing list saying what you plan to work on during that week. > (2) At the end of the week you send another mail saying what you managed > to do and what you didn't. > (3) When you take an important design decision you send a mail > describing the problem, listing the possible solutions, saying what > solution you prefer and asking for opinions. > > (4) Before committing you review your diff and describe all changes in > the commit log. If changes are not related then split the commit. > I will do those from this week. > ----- > > Regarding your last commits, the way suggestions are displayed is not > important at this point. You should focus first on: > > (A) Detect the auto-complete context based on the caret position. You > don't have to display anything for a start. You can simply log the > context in the Firebug console. > > (B) Get the list of suggestions based on the current context. Again, you > don't have to display them for a start. Simply log them in the Firebug > console. > > (C) Compute the pixel-based position where the suggestion list would be > displayed based on caret character-based position. > > (D) Display the list of suggestions. > > As you can see, you started with (D) which is IMO the least important. > You should not have to deal with CSS until you have everything working. > I have implemented A,C,D in a raw way, I have already committed D first, so I want to solve the review diff problem first, so that you can review my codes much easier, and then I will refine A, and commit it next week > > Thanks, > Marius > > > > > In last week I have committed two modules: > > > > 1. suggestion box for link > > (http://farm6.static.flickr.com/5268/5599744930_ff65ddfdc3_z.jpg) > > 2. suggestion box for image > > (http://farm6.static.flickr.com/5063/5600563446_5f15f500d1_z.jpg) > > > > I have also written a readme document in the same dir of the two > > modules, to guide developers to run and test the modules seperately. > > > > > > -- > > Best wishes, > > > > 许凌志(Jame Xu) > > > > MOE KLINNS Lab and SKLMS Lab, Xi'an Jiaotong University > > > > Department of Computer Science and Technology, Xi’an Jiaotong University > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Best wishes, 许凌志(Jame Xu) MOE KLINNS Lab and SKLMS Lab, Xi'an Jiaotong University Department of Computer Science and Technology, Xi’an Jiaotong University _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
