On Jul 31, 2011, at 9:28 PM, Caleb James DeLisle wrote: > I see you have left comments here and in jira and neither of them seem to be > there anymore. > My reason for placing it in oldcore is the same as my reason for not using > ConfigurationSource. > The main store is chosen from a key in the xwiki.cfg file, if there's a > ConfigurationSource for xwiki.cfg then I would like to know about it. > I could have proposed moving the main store key to xwiki.properties but I > made a guess that a proposal like that wouldn't fly. > If a user ever does switch to a different store, telling him that he needs to > change two configuration keys in two different files so that developers don't > go in debt would not make sense to him.
Yep, I figured this out, which is why I removed my comments ;) (also I wanted to figure out if there's a better way before commenting more - at a quick glance I haven't found any better solution). Thanks and sorry for the initial comment (I should have known better than to answer in the morning after going to bed at 4 o'clock in the morning ;)). -Vincent > Caleb > > On 07/31/2011 02:45 AM, vmassol wrote: >> I don't like the way you've fixed it too much (you've introduced some hacks) >> since using Initializable is the standard way of initializing components. >> The problem here can be fixed easily by not using the XWikiContext which in >> any case shouldn't be used. Instead configuration should come from a >> Configuration Source. >> >> Also you seem to be injecting the query executor but in init() you're >> looking it up again. >> >> Could you explain the need for this class and why it's located in the >> oldcore rather than being in the query manager's module? >> >> Thanks! _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
