On Thu, Aug 4, 2011 at 9:10 PM, Thomas Mortagne <[email protected]> wrote: > On Thu, Aug 4, 2011 at 7:26 PM, Jerome Velociter <[email protected]> wrote: >> Hello devs, >> >> I finally found a way to work with an issue in our REST annotation API >> that prevented to upgrade to Restlet 2.0.8 (see >> http://jira.xwiki.org/jira/browse/XWIKI-6632). >> >> The upgrade introduces some non-backward compatible change in 5 >> classes in the REST server module. Mostly Restlet plumbing (that >> probably should have been in an internal package in the first place). >> >> You can see the incriminated classes here : >> https://github.com/jvelo/xwiki-platform/commit/ebda7e5792839a89164f9fa27c15e5f0b95b4a9f#diff-0 > > There is only one java class in this commit and it's an internal one.
Yes, I was just pointing to the list in the pom.xml :) the modifications are in an other commit, namely https://github.com/jvelo/xwiki-platform/commit/8cf2940ffebb6b34e7abadd7c7d61d5c3a99b53d > >> >> If anyone here knows of any reason why this classes should not be >> broken, let them speak now, or forever hold their peace. > > If it's not what you already planned I would suggest to actually move > what should be internal package in it right now to not have the same > issue again next time we need to modify them. I'll do it in a separate commit, at least for some of the classes (for some I'm not so sure, maybe they should remain non-internal classes). Jerome > >> >> Peace, >> Jerome >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs >> > > > > -- > Thomas Mortagne > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
