Hi James, Don't forget to remove https://github.com/jamesxu326/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-web/src/main/webapp/resources/js/xwiki/editors/auto-suggestion-readme and https://github.com/jamesxu326/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-web/src/main/webapp/resources/js/xwiki/editors/suggestLuceneService . Also, please add a README file (see http://help.github.com/create-a-repo/#_create_a_readme_for_your_repo ) to your xwiki-platform fork to specify:
* the purpose of your fork (describe in a few sentences the feature you have implemented) * what modules/files have been changed, describing the change * what modules/files have been added, describing their purpose * the steps needed to integrate your work in an existing/running XWiki Enterprise instance (make sure you try the steps yourself on a clean XWiki Enterprise instance) Thanks, Marius 2011/8/17 Marius Dumitru Florea <[email protected]>: > On Sun, Aug 14, 2011 at 8:34 PM, Vincent Massol <[email protected]> wrote: >> Hi James, >> >> On Aug 14, 2011, at 11:43 AM, 许凌志(Jamesxu) wrote: >> >>> Hi, Last week I have done following things: >>> 1.Implemented the relative references for link generation >>> 2. implemented the default suggestions for sub-trigger "attach:", "." and >>> "@" >>> The default suggestion for trigger "attach:" is the attachments that >>> belongs to recently modified pages. >>> The default suggestion for trigger "." has two different situations: >>> 1). when "." is after "attach:" the default suggestion is the >>> attachments that belongs to recently modifed pages under the specific space >>> 2). when "." is not after "attach:" the default suggestion is the wiki >>> pages under specific space. >>> The default suggestion for trigger "@" is the attachments that belongs >>> to the specific wikipage. >>> 3. Re-design the interface of the suggestion box according to Marius' >>> suggestions, and it attracts some advantages from the suggestion box of >>> confluence wiki. >>> >>> Till now the Major functions for link suggestion of wiki editor has been >>> done, here is the video of the link suggestion for wiki editor. >>> Please see the demo video: http://www.youtube.com/watch?v=2_be-3oqgzE >>> In next week, I will do the following things； >>> 1. Design the image suggestion functions and discuss with mentors. >>> 2. Test the link suggestion functions in IE, chrome, to consider the >>> compatibility of the functions. >>> 3. Refine the functions accroding to the review of mentors. >> >> Sounds cool. >> >> Some questions: >> - What's the status of the integration of your code into the platform? Is it >> ready to be integrated? >> - Is it clean code or do you need to clean things up? >> - Do you have automated tests for it to prove that it works and that it'll >> continue to work in the future? >> > >> Basically I think you should start to focus on the integration part/clean >> up/stabilization/testing part since the end of summer is approaching fast :) > > I agree with Jerome. This is the last week (the dead line is next > Monday, 22 August) and you should focus on polishing the link > suggestion feature that you have implemented. There is no time for > image and macro suggestion. You can work on these after the GSoC > program ends if you are willing to, your contribution would be very > appreciated. > > I'll review your code. Ping me on IRC if you have questions. > > Thanks, > Marius > >> >> Is there a way to test what you have written so far? (it's ok if I have to >> build it). >> >> Thanks >> -Vincent >> >>> -- >>> Best wishes, >>> >>> 许凌志(Jame Xu) >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs >> > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
