On Sep 20, 2011, at 11:06 AM, Thomas Mortagne wrote: > On Tue, Sep 20, 2011 at 10:40 AM, Vincent Massol <[email protected]> wrote: >> >> On Sep 19, 2011, at 8:41 PM, Thomas Mortagne wrote: >> >>> On Mon, Sep 19, 2011 at 6:45 PM, Vincent Massol <[email protected]> wrote: >>>> Hi devs, >>>> >>>> Thomas just told me that he's made a change for Extension Manager >>>> (apparently there was a vote for it and I missed it - I can't find it so >>>> if anyone has the link please point me to it) and that by default now the >>>> Extension Manager uses the temporary directory to store installed >>>> extensions (Before it was using ~/.xwiki). >>> >>> I never said that, EM is using XWiki container standard work directly >>> like attachment files and Lucene for example. What the directory is is >>> up to the container component implementation and not EM. It just >>> happen that when you don't specify work directory the servlet >>> temporary directory is used. >> >> This is very wrong. AFAIR we discussed about how to name that directory and >> we called it "permanent storage directory" AFAIR. Using the servlet tmp dir >> as the permanent storage directory is asking for trouble. >> >>> The vote was about making standard work directory available to >>> components and I don't see why a vote is needed for a component to use >>> the standard XWiki work directory. >>> >>> If there is anything to decide it's where is the standard XWiki work >>> directory since both Lucene and FS attachments have the exact same >>> issue >> >> Yes although not quite, see below >> >>> but it has nothing do do with EM IMO. >> >> IMO you're confusing things because you see them from a technical point of >> view. What we've done is a regression from the point of view of the user. >> While previously his extensions were stored in a safe persistent location, >> now when he downloads XE, it's stored in a temporary location by default. >> The user doesn't care whether technically what we've done is correct or not. >> It's bug from a user POV. >> >>>> I thus want to throw my -1 to release 3.2 final with this (I'd also much >>>> prefer if 3.2M3 doesn't have it as much as possible). The reason is that >>>> the tmp/ directory can get wiped anytime and the user can thus suddenly >>>> loose all its installed extensions. I believe we need a permanent location >>>> for that. >>>> >>>> We have 2 general options IMO: >>>> >>>> 1) Don't start xwiki if the work directory is not explicitly configured >>>> 2) Make the default EM work directory be the same as before (ie ~/.xwiki), >>>> when the work dir config property is not defined >>>> >>>> I also want to propose that for the standalone distribution of XE (the >>>> jetty/hsqldb package) we use work/ as the work directory. We already >>>> create this directory and we should use it (it's already used by our >>>> lucene indexing BTW). >> >> Actually the lucene index files don' t really need a directory as stable as >> the extension directory since lucene indexes can be removed at no harm. It >> won't change any behavior of XE and the indexes will be recreated when XE >> starts. > > It's not just about Lucene, you are forgetting FS attachments.
Yes FS attachments need a stable permanent storage location same as for EM extension data. IMO the data/ directory I mentioned below (for the standalone distribution) is good for that. WDYT? Thanks -Vincent >> So we could use the same location but ideally we'd need a better and more >> stable directory for EM extensions. BTW we decided not to call the directory >> "work" in the code so we should probably not call it "work" on the FS either. >> >> I think we should rename it to data/ for example and use that directory for >> the lucene files for now. >> >> WDYT? >> >> BTW I'd also like that we progressively move the xwiki config files to this >> directory (xwiki.cfg, xwiki.properties) to make it real easy to save/find >> xwiki data and so that installing a new version of the XE WAR doesn't >> override them. >> >>> That's because it's explicitly set in xwiki.cfg so to have the same >>> behavior all that is needed is to set it the same way in >>> xwiki.properties. >> >> Let's do it then. >> >> Thanks >> -Vincent >> >>>> WDYT? >>>> >>>> Thanks >>>> -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
