On Wed, Oct 12, 2011 at 4:22 PM, Thomas Mortagne <[email protected]> wrote: > On Wed, Oct 12, 2011 at 4:16 PM, Vincent Massol <[email protected]> wrote: >> >> On Oct 12, 2011, at 12:21 PM, Thomas Mortagne wrote: >> >>> On Wed, Oct 12, 2011 at 11:50 AM, Thomas Mortagne >>> <[email protected]> wrote: >>>> On Wed, Oct 12, 2011 at 10:21 AM, Thomas Mortagne >>>> <[email protected]> wrote: >>>>> On Wed, Oct 12, 2011 at 9:50 AM, Sergiu Dumitriu <[email protected]> wrote: >>>>>> On 10/12/2011 03:42 AM, Thomas Mortagne wrote: >>>>>>> On Wed, Oct 12, 2011 at 9:27 AM, Sergiu Dumitriu<[email protected]> >>>>>>> wrote: >>>>>>>> On 10/11/2011 10:04 AM, Thomas Mortagne wrote: >>>>>>>>> hi devs, >>>>>>>>> >>>>>>>>> The idea is that in Maven in general you should never embed anything >>>>>>>>> except for final distribution packages that are not supposed to be >>>>>>>>> used as dependencies of other maven projects (installers, standalone >>>>>>>>> packages, etc.). This will also allow us to properly setup >>>>>>>>> dependencies in xar so that dependency is installed when installing a >>>>>>>>> xar in Extension Manager without its pages being imported twice. >>>>>>>>> >>>>>>>>> So I propose the following changes: >>>>>>>>> * in xar plugin: >>>>>>>>> ** stop embedding dependencies as default behavior >>>>>>>> >>>>>>>> +1 >>>>>>>> >>>>>>>>> ** introduce an optional property for it. >>>>>>>> >>>>>>>> +0 >>>>>>>> >>>>>>>>> * in XE/XEM have two different xars: >>>>>>>>> ** a normal one with just XE pages and proper dependencies setup >>>>>>>>> ** a "standalone" one which embed all XE dependencies xar (basically >>>>>>>>> the one we have now) >>>>>>>> >>>>>>>> Not quite sure I like this. >>>>>>>> >>>>>>>> First, we're supposed to be moving documents out of xwiki-enterprise >>>>>>>> and >>>>>>>> into application modules inside the platform, so there shouldn't be any >>>>>>>> XE XAR at all, just a list of default dependencies to include in the >>>>>>>> standalone database. >>>>>>> >>>>>>> Yes we are supposed to be I'm pretty sure it's not going to happen in >>>>>>> 3.3 and IMO it's another subject. Also you forget some pages like >>>>>>> Main.WebHome that are still specific to XE and could not go in any >>>>>>> platform application IMO, everything in XEM is properly in application >>>>>>> located in platform but you still have some specific XEM pages. >>>>>>> >>>>>>>> >>>>>>>> Second, if we do push forward the extension manager as the preferred >>>>>>>> way >>>>>>>> of installing XARs, then such a bundle XAR shouldn't be needed at all. >>>>>>>> For the standalone distribution the packager plugin could just install >>>>>>>> the XE shallow XAR + its dependencies, while for WAR installs users >>>>>>>> could just pull it using the extension manager. So, the big fat XAR >>>>>>>> shouldn't have any use either. >>>>>>> >>>>>>> In the future of course but we are not ready for it right now. It's >>>>>>> not like I'm proposing to introduce a standalone package, it's already >>>>>>> here. Let's not rush it. >>>>>> >>>>>> Indeed. So yes, for a quick fix for the moment, while waiting for better >>>>>> solutions, we do need the two packages. >>>>>> >>>>>> I wasn't -1, I was just a reluctant +0.5 knowing that there will be >>>>>> better options in the future. >>>>>> >>>>>> How do you envision this, implementation-wise? Two maven modules, one >>>>>> with documents the other as a bundle, or two build artifacts from the >>>>>> same module? >>>>> >>>>> Definitely two modules. With the bundle somewhere in >>>>> https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distribution/ >>>>> since that's what it is. >>>>> >>>>> Then I'm not sure if the not bundled xar will be >>>>> https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki >>>>> or a package in >>>>> https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-manager-applications >>>> >>>> https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-applications >>>> >>>>> like I tried to do with XEM (which already have this separation >>>>> between proper application but without the dependencies since it was >>>>> not possible and the bundled package). >>> >>> I propose >>> >>> * xwiki-enterprise-ui >>> * xwiki-enterprise-distribution/xwiki-enterprise-ui-all >>> >>> WDYT ? >> >> So you want to: >> * rename >> https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-wiki >> into >> https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-ui >> * add a new >> https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distribution/xwiki-enterprise-ui-all >> ? >> >> hmmm ok why not.. I wonder if we need a new directory level though for >> container distributions: >> https://github.com/xwiki/xwiki-enterprise/tree/master/xwiki-enterprise-distribution/xwiki-enterprise-distribution-containers/* >> (so that there's a common pom for them to put common stuff) >> >> Right now distribution meant container distributions but putting -ui-all in >> it changes the meaning, it introduces a new type of distribution. >> >> >> It's not really a distribution in the sense that it doesn't packages XE. It >> only packages a small subset of XE. > > Actually for me distribution mean a final package you only distribute > and that you are not supposed to use in another maven project (except > for things like test where you actually want to test the distributed > package). Actually I would also move installer in the distribution > folder if you ask me.
An in that case yes I'm ok with a xwiki-enterprise-distribution-containers subdirectory. > >> I'm still hesitating with this: >> >> /xwiki-enterprise-uis/ >> |_ xwiki-enterprise-ui/ >> |_ xwiki-enterprise-ui-all/ >> >> Thanks >> -Vincent >> >>>>>>>>> WDYT ? >>>>>>>>> >>>>>>>>> Here is my +1 >> >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs >> > > > > -- > Thomas Mortagne > -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
