+1 (non binding) --G 2011/10/27 Thomas Mortagne <[email protected]>
> On Thu, Oct 27, 2011 at 12:55 AM, Vincent Massol <[email protected]> > wrote: > > > > On Oct 26, 2011, at 7:09 PM, Thomas Mortagne wrote: > > > >> Hi devs, > >> > >> Right now it's not very easy for a macro to properly deal with content > >> parsing especially the way to find which syntax to use to parse the > >> content. > >> > >> There is a very useful tool that we are using internally but its not > >> public so contribution macros can't use that. > >> > >> I propose to move > >> org.xwiki.rendering.internal.macro.MacroContentParser to > >> org.xwiki.rendering.macro.MacroContentParser. > >> > >> WDYT ? > >> > >> Here is my +1 > > > > +1 but maybe the interface needs to be reviewed to verify it's ok. I'm > not sure why we need the 2 methods that are there now. That doesn't look > right. > > Sure, the first one does not seems very useful. I mean it is but there > is no need to provide a method for something that is just > xdom.getChildren(). > > I would also like to put getCurrentSyntax as public method since it > could be very useful too and not that easy to reproduce. > > > > > Thanks > > -Vincent > > > > _______________________________________________ > > devs mailing list > > [email protected] > > http://lists.xwiki.org/mailman/listinfo/devs > > > > > > -- > Thomas Mortagne > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
