On Nov 28, 2011, at 6:24 PM, Guillaume Sauthier (Objectweb) wrote: > 2011/11/28 Vincent Massol <[email protected]> > >> Hi Guillaume, >> >> On Nov 28, 2011, at 4:40 PM, Guillaume Sauthier (Objectweb) wrote: >> >>> Hi all >>> >>> It's a following of the recent discussion on this list :) >>> >>> I have provided the basis for a java backed {{panel}} macro >> implementation. >>> The source code is currently hosted on my github account, but I would >> like >>> to move it under xwiki-contrib. >> >> I've created a repo for you: >> https://github.com/xwiki-contrib/macro-panel >> > > Thanks > I've moved the code from my own repo to this one.
I had forgotten to configure email notifications. Done now. >>> See https://github.com/sauthieg/xwiki-panel-macro >>> >>> I've inited an extension page for this macro on the extension wiki: >>> http://extensions.xwiki.org/xwiki/bin/view/Extension/Panel+Macro >>> >>> BTW, what is the type for a Java Macro ? Macro type seems to be >> restricted >>> to Velocity … >> >> It should be components (the other macro types are for old deprecated >> technology). I've fixed it and added the download link too for you (there >> are instructions when you edit the extension page on how to do that BTW). >> > > Oops, missed that point :) > > >> >>> Any interest ? >> >> Yes looks useful to me and we should move it to xwiki-platform IMO (after >> reviewing it and finding a way to remove the hack that I saw there to get >> the panel doc, if possible ;)). >> > > I'm sure that I couldn't invent that piece of code myself, someone had > probably helped me :) > Maybe you ;) It was me indeed. > BTW, I tried to move to latest xwiki-commons module (3.3-milestone-1), and > I hit some issues, so I did not incorporate theses changes in what I pushed. > The first one is that the AbstractLogEnabled class is no more in the > dependencies, To get logs now you just need to get the SLF4J logger injected, see http://extensions.xwiki.org/xwiki/bin/view/Extension/Component+Module#HComponentLogging > and when launching the tests, a component was probably still > using it. I found that class in an older commons module (3.2-milestone-x), > but it was not very clean :'( > The other one (and I gave up on this one) was that the RenderingTest was > complaining about not being able to find a Parser component … Can't think of an issue for this one, I'd need to try it out to see the full error. Thanks -Vincent > --G > > >> >> Thanks! >> -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
