Hi Marius,

I think the display module should be independent of the Velocity module.

I see that the VelocityManager is used in DocumentContentDisplayer but I don't 
think that's nice. It's used to isolate the velocity context in case velocity 
is used. I think we can improve this for the following reasons:

1) We don't always need to render content using velocity
2) Code using the displayer shouldn't need to depend on velocity if it doesn't 
need to

I think a better solution would be to have some generic component interface for 
isolating content (we might already have this) and then have the displayer call 
"registered" components without knowing them.

This would mean that the code isolating the velocity namespace would be located 
in the velocity module itself for ex (or in a sub module) which makes more 
sense IMO.

WDYT?

Thanks
-Vincent

_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to