On Thu, Jan 19, 2012 at 8:57 AM, Paul Libbrecht <[email protected]> wrote: > As long as you have a syntax for the future as you sketch below that's ok. > Your previous examples didn't show two lines of comments. > > I'm surprised, though, that you have the renaming scenario in mind only, it > is rarely needed while the "fuzzy renaming" is quite often needed to my > experience.
It's not the only thing I have in mind, it's the only thing I plan to do shortly because me have a need for it right now: most of the XE translation keys are going to be renamed while we move the page to separate applications. What do you mean by "fuzzy renaming" ? > > What is the flow of deprecation, how would a developer or tester be warned of > a deprecated message? This is not going to change, the current rule is that when you need to rename a translation key you move the old one in a deprecation section of the translation file and we are supposed to remove the key when it's not used anymore in any active branch (we actually forgot to remove lots of older translations when deleting branches). The proposal here is not about how do we deprecate translations, I just want to propose a syntax to indicate what is the new name of a deprecated translations which is not a new concept itself. > > paul > > > Le 19 janv. 2012 à 08:26, Thomas Mortagne a écrit : > >> On Wed, Jan 18, 2012 at 9:37 PM, Paul Libbrecht <[email protected]> wrote: >>> Don't you also need: >>> >>> #@deprecated "because we stopped this application in release 1.12.2" >>> >>> #@deprecated "new.key.name: either this or that or that" >>> >>> ? >>> >>> I'm afraid your syntax is a bit too tiny. >>> I'm definitely encouraging the use of deprecation in i18n messages. >>> Is there or will there be a server to monitor the use of deprecation, >>> and/or analyze it so that they can be removed by proper changes inside the >>> code?? This would be very valuable! >> >> Right now I'm only interested in indicating the new name of the key >> and that's my only need in a short term. It's very easy to add later >> other informations like: >> >> #@deprecated new.key.name >> #@since 3.4 >> old.key.name=Default translation >> >> but I would prefer to do it one by one. >> >>> >>> paul >>> >>> Le 18 janv. 2012 à 17:50, Thomas Mortagne a écrit : >>> >>>> Hi devs, >>>> >>>> Right now renaming a key is a pain if we don't want to loose the >>>> existing translations associated to it. Basically it require to rename >>>> the key in all languages and reimport all of them on l10n.xwiki.org. >>>> >>>> We already have a section in the translation file to indicate which >>>> translations are deprecated. The idea is to indicate what is the new >>>> name of a deprecated translation key directly in the translation file >>>> so that l10n.xwiki.org can automatically copy the translation to the >>>> new key when it find a new deprecated key while importing default >>>> translation file. >>>> >>>> For that we need to decide a syntax to indicate what is the new name of >>>> the key. >>>> >>>> I propose to do something similar to java and indicate it in a comment >>>> like the following: >>>> >>>> new.key.name=Default translation >>>> >>>> #@deprecated new.key.name >>>> old.key.name=Default translation >>>> >>>> Here are some other alternatives to "deprecated": >>>> >>>> * replacedBy >>>> * new >>>> >>>> others ? >>>> >>>> Here is my +1 for "deprecated", more intuitive for Java developers and >>>> it's clear it's a deprecated translation key. >>>> >>>> Thanks, >>>> -- >>>> Thomas Mortagne >>>> _______________________________________________ >>>> devs mailing list >>>> [email protected] >>>> http://lists.xwiki.org/mailman/listinfo/devs >>> >>> _______________________________________________ >>> devs mailing list >>> [email protected] >>> http://lists.xwiki.org/mailman/listinfo/devs >> >> >> >> -- >> Thomas Mortagne >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
