Le 5 avr. 2012 à 20:37, Fabio Mancinelli a écrit : > On Thu, Apr 5, 2012 at 8:32 PM, savitha sundaramurthy > <[email protected]> wrote: >> >> Hi Paul, >> >> On Thu, Apr 5, 2012 at 1:52 AM, Paul Libbrecht <[email protected]> wrote: >> >>> Ok, so this is a little script reporting usage. It looks ok but I need >>> to >>> touch software. >>> >>> >> My code is here: >> https://github.com/savee1/xwiki-platform/tree/SOLR/xwiki-platform-core/xwiki-platform-search
Ah, now I can see how this is forked... great! Interesting is that we see the history of contribs for each. In particular the commit of Savitha on top of yours. >>> Also, I insist on forking for me to see the diffs. >> I have forked the code, Sent a pull request to fabio. My commit and the >> list of diffs for all the files. >> > Yep I've seen it, though I don't think it's the correct way to proceed. > The pull request, in fact, is sent to a branch of a fork in my account. The language "pull request" is a bit bizarre but it really means "pull back", and that back would be indeed to Fabio's tree. Sure, this should be done on xwiki-platform-search on the long run. For now, let's stick to Savitha's repo. > I think that this kind of development should be done in a more > "institutional" place like xwiki-contrib. > > Moreover, since I am not the mentor for this project, I am not > entitled to merge pull requests. > So I propose to open a fork of xwiki-platform in xwiki-contrib, and > that Savitha works on that fork and (re)send pull requests there. I think we have to wait till this gets reviewed thoroughly... no urgency here. But now I see the contribution of Savitha, that is the key to evaluate. paul _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
