Results: +1: 4 +0: 0 -1: 0 Vote passed.
Applied with Sergiu's suggestion. Thanks, Eduard On Mon, May 28, 2012 at 12:21 PM, Ecaterina Moraru (Valica) < [email protected]> wrote: > +1 > > Thanks, > Caty > > On Sat, May 26, 2012 at 8:01 PM, Sergiu Dumitriu <[email protected]> wrote: > > > On 05/25/2012 11:48 AM, Eduard Moraru wrote: > > > >> Hi devs, > >> > >> I`ve recently worked on extracting the textarea input from the activity > >> stream macro into a separate and reusable {{messageSender}} macro that > is > >> able to do just that, send messages. By default, the activity macro will > >> still display the messages text area (by including itself the > >> messageSender > >> macro), but it can also be disabled by passing the messageSender='false' > >> parameter to the activity macro. > >> > >> The new messageSender can be used wherever you want to be able to send a > >> message and do not want to carry the whole activity stream with you > (with > >> all it's performance and layout impact). > >> > >> Please check out the Jira issue [1] and the available pull requests > [2][3] > >> for additional details. > >> > >> I`d like your vote on whether or not we want to include this into > >> platform. > >> > > > > +1. See my comment on the issue, about the event name. > > > > > > Here's my +1. > >> > >> If your vote is positive, should we add it for 4.1M2 (which is scheduled > >> on > >> Monday)? > >> > > > > I'd say yes. > > > > > > Note that I am also working on adding filtering support to the activity > >> macro and am planning to build on top of this :) > >> > >> Thanks, > >> Eduard > >> > >> ---------- > >> [1] http://jira.xwiki.org/browse/**XWIKI-7679< > http://jira.xwiki.org/browse/XWIKI-7679> > >> [2] https://github.com/xwiki/**xwiki-enterprise/pull/22< > https://github.com/xwiki/xwiki-enterprise/pull/22> > >> [3] https://github.com/xwiki/**xwiki-platform/pull/48< > https://github.com/xwiki/xwiki-platform/pull/48> > >> > > > > -- > > Sergiu Dumitriu > > http://purl.org/net/sergiu/ > > > > ______________________________**_________________ > > devs mailing list > > [email protected] > > http://lists.xwiki.org/**mailman/listinfo/devs< > http://lists.xwiki.org/mailman/listinfo/devs> > > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
