+0 Thanks, Marius
On Tue, Jun 5, 2012 at 1:05 PM, Thomas Mortagne <[email protected]> wrote: > Hi devs, > > Despite what the documentation is saying anyone can register a wiki > macro for the whole wiki so I'm about to fix it. See > http://jira.xwiki.org/browse/XWIKI-7880. > > But to fix it properly IMO I need to add a right checking method to > the wikimacro/oldcore own bridge. > > Right now the right check is a pile of hacks using various APIs > (WikiModel for edit, DocumentAccessBridge for programming) and there > is no way to test admin right in existing bridges and APIs anyway. > Instead of adding more hacks to the current wiki macro right checking > I find it better to move the check itself to its existing own model > bridge and test it there using the rightservice directly. It also make > more sense to have this check at the wiki macro model bridge level > than the wiki macro component itself. > > This is a pretty hidden API that noone is supposed to use except the > wiki macro and oldcore but since it's a public interface it makes > CLIRR complains so according to our rule here is the vote for adding > this new method. > > WDYT ? > > Here is my +1. > > Since the master is now on 4.2 branch I'm committing it right now. > Will revert it if anyone gives a veto. > > -- > Thomas Mortagne > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
