On 06/18/2012 04:41 AM, Thomas Mortagne wrote:
Hi devs,Here is what XWikiAttachment#setFilename looks like public void setFilename(String filename) { filename = filename.replaceAll("\\+", " "); if (!filename.equals(this.filename)) { setMetaDataDirty(true); this.filename = filename; } this.reference = null; } Seriously ? That does not make any sense and there is not even a comment for it. I would go for removing this replaceAll and forget about anything that really expect this API to do something that bad and avoid retro-compatibility nightmare. WDYT ? Here is my +1.
+1. -- Sergiu Dumitriu http://purl.org/net/sergiu/ _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
