Being stuck in the middle of such a process I understand the rationale: go
down, let the backup happen or something such, then only open the doors from
outside and start serving.
Maybe the right thing to offer is to run a script instead of going down?
I would add to it to send a mail just before... since doing this might be
configured in xwiki and it is harder in scripts?
Paul
Le 19 juin 2012 à 13:05, Vincent Massol a écrit :
> Hi devs,
>
> I see that Denis has added the following:
>
> if ("1".equals(config.getProperty("xwiki.store.migration.exitAfterEnd",
> "0"))) {
> logger.error("Exiting because xwiki.store.migration.exitAfterEnd is
> set");
> System.exit(0);
>
> This is really bad IMO since System.exit should never be used in
> JavaEE/Servlet apps.
>
> See also
> http://nemo.sonarsource.org/drilldown/violations/XWIKI?rids%5B%5D=367322&rule=pmd%3ADoNotCallSystemExit&rule_sev=INFO#L425
>
> One problem for example is that this will stop the full Servlet JVM so if
> XWiki runs in a Servlet container running several other webapps suddenly the
> whole Servlet container will go down!
>
> What should be done instead is to remove this "feature" which has no real
> meaning in a Servlet environment.
>
> I'm thus proposing to deprecate this feature. I don't even understand what
> use cases it brings.
>
> WDYT?
>
> Thanks
> -Vincent
>
>
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
