On Thu, Jun 21, 2012 at 8:22 AM, Vincent Massol <[email protected]> wrote: > Hi Eddy, > > On Jun 21, 2012, at 1:55 AM, Eduard Moraru wrote: > >> Hi devs, >> >> Lately, I`ve been working on being able to filter the events that are >> displayed by the Activity Stream macro. >> >> I`ve implemented both the JavaScript and the no-JavaScript version and I`d >> like your vote on whether we want to merge it into master or not. >> >> Please have a look over the pull request [1][2] and let me know if you spot >> any bad decisions or bad code :) >> >> Here's my +1 > > Hey, I didn't know you were working on this! :) > (maybe I missed an email from you stating that you were going to work on this > - if not, might be good to have one next time) > > It looks like a cool feature (that's making our AS code even more complex to > maintain though but that part would probably stay even after we rewrite the > AS code in Java). > > Some questions below so that I can understand this a bit more :) > > So, if I understand properly this allows to filter what's displayed by the > Activity Stream independently of the parameters used in the activity macro. > Currently the macro has the following params: wikis, spaces, authors, tags, > minor/major, number of entries and number of subentries (see > http://extensions.xwiki.org/xwiki/bin/view/Extension/Activity+Macro). > > So does it mean that the parameters you use on the macro are considered to be > just defaults that the user can then modify live? >
> Those filters are not saved, are they? (meaning if you refresh the page or go > to another page and come back, they're lost) The filters should be 'saved' in the URL fragment identifier like it happens with the live table filters. Thanks, Marius > > Do you support filtering on all the params supported by the AS: wikis, > spaces, authors, tags, minor/major, number of entries and number of > subentries ? > > On http://jira.xwiki.org/browse/XWIKI-6698 it's mentioned that you can filter > to show ALL activity. Do you handle pagination? If not there's an obvious > problem of performance. > > Is there a way to pass the filters in the request so that we can create links > to filtered AS? > > Thanks > -Vincent > >> Thanks, >> Eduard >> >> ---------- >> [1] https://github.com/xwiki/xwiki-enterprise/pull/27 >> [2] https://github.com/xwiki/xwiki-platform/pull/55 > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
