Hi Savitha, On Aug 16, 2012, at 11:28 PM, savitha sundaramurthy wrote:
> Hi Vincent, > > I haven't created any JIRA issues for my past work and thanks > a lot for creating a JIRA component. > > I was looking out for best practices or documentation of unit > and functional test cases but could not find much. Could you suggest some > examples or best practice for testing, both unit and functional?" See http://dev.xwiki.org/xwiki/bin/view/Community/Testing Thanks -Vincent > Thanks a lot, > Savitha. > > On Thu, Aug 16, 2012 at 1:53 PM, Vincent Massol <[email protected]> wrote: > >> >> On Aug 16, 2012, at 10:52 PM, Vincent Massol wrote: >> >>> Hi Savitha, >>> >>> On Aug 13, 2012, at 2:17 PM, savitha sundaramurthy wrote: >>> >>>> Hi Vincent, >>>> >>>> On Mon, Aug 13, 2012 at 12:03 AM, Vincent Massol <[email protected]> >> wrote: >>>> >>>>> Hi Guys, >>>>> >>>>> I haven't been that closely the SOLR GSOC work and it would be great to >>>>> see where we stand. >>>>> >>>>> I'd love to know the following: >>>>> >>>>> * What's the status of the code; is it following our best practices >> (code >>>>> style/passing checkstyle, unit tests, functional tests)? >>>>> >>>> >>>> I can say, 80% of code is complete. I tried to follow the best >> practices of >>>> xwiki development. Still there are few places with bad code and needs >> to be >>>> refactored. Few classes have cyclomatic complexity errors, that need to >> be >>>> refactored too. API is missing in few places. >>>> >>>> Am planning to work on the code refactoring for another two days and >> make >>>> sure checkstyle passes. >>>> >>>> Unit tests and Functional tests are in a bad state, and need to be >> worked >>>> on. >>>> >>>> >>>> >>>>> * What's the level of the UI in term of readiness, compared to our >> current >>>>> one? >>>>> >>>> >>>> UI is ready. Compared to the current lucene plugin, solr has more >> features >>>> and so a little complex UI. >>>> >>>> The new Advanced Search UI will have: >>>> >>>> - Filtered search ( Filter on Spaces, Language, Type, File type etc..) >>>> - Custom query boost >>>> - Faceted Search >>>> - Need some work to be done on links, at times they are giving >>>> weird results. >>>> - Creation date and date need to be changed to something human >>>> readable instead of dates. >>>> (i.e. Today, Last Week, Last Month, Year..) >>>> - Debug query >>>> - Debug search result >>>> - Sorting the results ( Relevance, Date, Author etc..) >>>> - Its one way now,only descending results are active for the above >>>> sort types, need to add ascending order too. >>>> >>>> I have kept the Administration UI to minimal features like indexing >>>> wiki/space, looking into solrconfig.xml and schema.xml files. Solr >> Server >>>> details like versions, components, files used. >>>> >>>> Two days of work around UI. Need to check with Caty on the new Advanced >>>> Search interface. >>>> >>>> >>>>> * Do we have all the features of the current Lucene plugin (including >>>>> improvements already listed in JIRA, we should verify that they can be >>>>> implemented with the current code if not already there) >>>>> >>>> >>>> Almost all the features supported by Lucene are supported by Solr. The >> only >>>> exception at this time is Auto Suggest in the quick search bar, am >> working >>>> on that. >>>> >>>> Can you give the link to JIRA, I can verify and let you know whether the >>>> features can be implemented with the solr component. >>>> >>>> >>>>> * Could we do drop-in replacement of the current search? >>>>> >>>>> Its not ready for immediate replacement. It does have all the features >>>> provided by lucene plugin. But the Advanced search features are having >> few >>>> issues, need to calibrate and tweak the search request. >>>> >>>> >>>>> In general, how much work remains to be able to commit this in platform >>>>> and start bundling it and using it in XE? >>>>> >>>> >>>> Work remaining: >>>> >>>> 1. Fix checkstyle errors >>>> 2. Auto Suggest feature >>>> 3. Admin UI >>>> 4. Minor bugs in Facet search to be fixed >>>> 5. Search calibration >>>> 6. Unit test cases and Functional test cases. >>>> >>>> Planning to do the following this week >>>> >>>> 1. Fix checkstyle errors >>>> 2. Auto Suggest feature >>>> 3. Fix the minor bugs. >>>> 4. Search calibration >>>> 5. Complete the documentation. >>>> >>>> Is it possible to have JIRA for Solr component so that it will be easy >> to >>>> track the bugs in future? >>> >>> Thanks for the details. The plan sounds good. >>> >>> I would have loved to be able to see your work in action but last time I >> tried your server was down. Any way I could test it? >> >> Ah just seen you other mail where you give this URL which seems to work: >> http://savitha.hoplahup.net/xwiki/bin/view/Main/AdvancedSearch >> >> Thanks! >> -Vincent >> >>> >>> Re JIRA I have created a component named "SOLR Search" for your to use >> when creating jira issues in the Contrib project: >>> http://jira.xwiki.org/browse/XCONTRIB >>> >>> Have you already created any JIRA issues for the past work or not? >>> >>> Thanks >>> -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
