On Fri, Sep 14, 2012 at 9:40 AM, [email protected] <[email protected]>wrote:
> Hi, > > I'm not a big fan of ObjectDefinition. > I follow up on this, I do not really see the benefit of it, and I really dislike the idea to have this one in two words, while all others are single. > > I would vote 1) or 3) with XObject and XClass. > but I do not like the inconsistency of the above choice, about the X, as Vincent mentioned. So I would be more in favor of: XWikiEntity, XSpaceEntity, XDocumentEntity, XObjectEntity and XClassEntity while for references we would need to have: XWikiReference, XSpaceReference, XDocumentReference, XObjectReference and XClassReference Having a single X prefixed word for all of them, will favor other combination in the code, where the initial prefix is that single XWord. It could also favor clear suffixes as well, in methods when needed. It could also help in case of future expansion. It allow to be very consistent. > > Jerome > ________________________________________ > From: [email protected] [[email protected]] on behalf of > Vincent Massol [[email protected]] > Sent: Friday, September 14, 2012 9:29 AM > To: XWiki Developers > Subject: [xwiki-devs] [VOTE] Name for Entity classes in the new model > > Hi devs, > > As you may have seen, I've been working on the new model in a branch. > > We need to decide on the naming of the Entity classes (wiki, space, > document, object, object definition, etc). > > We have several possibilities I know of for naming them: > > 1) Wiki, Space, Document, Object, ObjectDefinition > 2) WikiEntity, SpaceEntity, DocumentEntity, ObjectDefinitionEntity > 3) Wiki, Space, Document, XObject, XObjectDefinition (or simply > ObjectDefinition) > 4) XWiki, XSpace, XDocument, XObject, XObjectDefinition > 5) Some other name for objects. > > Some concerns: > * Using Object as in 1) is a bit of a pain since there's java.lang.Object > which forces to use the FQN name when coding in Java. Which is why I've put > proposals 2) and 3) > * In proposal 3) there's a bit of an inconsistency with the X in XObject > which is not present in the other entity names, hence proposal 4 and 2) > * In proposal 1) there can be some other clashes. For example Document can > clash with the DOM Document object > > My personal vote goes to 2), even though it makes the entity names a bit > longer. > > Cast your votes! > > Thanks > -Vincent > > > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
