Thanks, done for the WikiComponent and UIExtensions APIs. As for parameterized types, they're not taken into account, only the main Type is (for clirr a java.util.List<java.lang.String> is a java.util.List).
JV. On Fri, Oct 19, 2012 at 6:15 PM, Vincent Massol <[email protected]> wrote: > > On Oct 19, 2012, at 5:51 PM, Jean-Vincent Drean <[email protected]> wrote: > >> After looking at the doc >> (http://mojo.codehaus.org/clirr-maven-plugin/examples/ignored-differences.html) >> I tried to do this: >> >> --------------------------------8<-------------------------------- >> <groupId>org.codehaus.mojo</groupId> >> <artifactId>clirr-maven-plugin</artifactId> >> <configuration> >> <ignored> >> <differences> >> <difference> >> <className>org/xwiki/ircbot/IRCBot</className> >> <method>void initialize(java.lang.String)</method> >> <differenceType>7012</differenceType> >> <justification>IRCBot is still a young API. Added a >> new initialize() method to support installing the >> IRC Bot application in a subwiki</justification> >> </difference> >> <difference> >> <className>org/xwiki/component/wiki/WikiComponent</className> >> <method>Class getRole()</method> >> <differenceType>7002</differenceType> >> <justification>WikiComponent is still a young API. >> Removed the method to implement XWIKI-8233, >> "Allow wiki components to implement parameterized >> types"</justification> >> </difference> >> </differences> >> </ignored> >> --------------------------------8<-------------------------------- >> >> But it fails with the following error: >> >> [ERROR] Failed to execute goal >> org.codehaus.mojo:clirr-maven-plugin:2.5:check (clirr-check) on >> project xwiki-platform-core: Unable to parse configuration of mojo >> org.codehaus.mojo:clirr-maven-plugin:2.5:check for parameter >> differences: Cannot find setter, adder nor field in >> org.codehaus.mojo.clirr.Difference for 'difference' -> [Help 1] >> >> Does this mean the maven plugin doesn't handle the "differences" tag ? > > Correct. See > http://jira.xwiki.org/browse/XCOMMONS-283?focusedCommentId=72397&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-72397 > > Thanks > -Vincent > >> >> Another issue I can think of is pameterized types, for example >> "Class<?>", but I guess we can xml encode that. >> >> On Fri, Oct 19, 2012 at 10:24 AM, Vincent Massol <[email protected]> wrote: >>> Hi guys, >>> >>> I've committed http://jira.xwiki.org/browse/XCOMMONS-283 which allows us to >>> very precisely exclude CLIRR violations. >>> >>> See >>> http://mojo.codehaus.org/clirr-maven-plugin/examples/ignored-differences.html >>> for details. >>> >>> For example I've just added an IRCBot exclude using this with: >>> >>> <ignored> >>> <difference> >>> <className>org/xwiki/ircbot/IRCBot</className> >>> <method>void initialize(java.lang.String)</method> >>> <differenceType>7012</differenceType> >>> <justification>IRCBot is still a young API. Added a new >>> initialize() method to support installing the >>> IRC Bot application in a subwiki</justification> >>> </difference> >>> </ignored> >>> >>> Now could every one who's added a clirr exclude please convert to the new >>> way? >>> >>> This allows us to have fine-grained excludes and not exclude the whole file. >>> >>> Thanks >>> -Vincent >>> >>> _______________________________________________ >>> devs mailing list >>> [email protected] >>> http://lists.xwiki.org/mailman/listinfo/devs >> >> >> >> -- >> Jean-Vincent Drean, >> XWiki. >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
