On 10/19/2012 05:47 PM, Fabio Mancinelli wrote:
On Fri, Oct 19, 2012 at 9:16 PM, Vincent Massol <[email protected]> wrote:
Devs,
We're receiving tons of build failures every day again …. :(
Coud all devs please help in fixing the build so that we can again have a
passing build and fix flickering tests?
I looked a bit at the build...
The problem is in the
xwiki-platform-core/xwiki-platform-web/src/main/webapp/resources/uicomponents/dashboard/dashboard.css
and in particular in this block of code:
#css3_backgroundLinearGradient({
'to': 'top',
'colors': [
{'color': $theme.panelHeaderGradientColor, 'position': '0%'},
{'color': $theme.panelHeaderBackgroundColor, 'position': '100%'}
]
})
Apparently yuicompressor doesn't like nested {}, so that macro makes it explode.
I've also find an IRCLog where Marius talked about a similar issue
(http://dev.xwiki.org/xwiki/bin/view/IRC/xwikiArchive20100920)
An idea to fix it is to add a macro #css_panelHeaderLinearGradient()
that wraps the block in colorThemeInit.vm and call it instead of
#css3_backgroundLinearGradient. The other obvious way would be to
macro expand inline the #css_backgroundLinearGradient macro, but it's
very complicated and it would not be readable.
A patch is in the attachment.
-Fabio
P.S.: The same macro is called also in
xwiki-platform-web/src/main/webapp/resources/js/xwiki/widgets/modalPopup.css
which doesn't seem to be minified.
The usual approach is to skip the minification of such files.
--
Sergiu Dumitriu
http://purl.org/net/sergiu/
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
