Eduard, that's nice to see it progresses. I have not had the time to review but the screenshot help me do so quickly.
Small comments: - Do you want to keep debug always on? I would disable the debug links and checkbox for normal users, activating if globalAdmin or if a setting is defined - Query boost does not sound right to me. I'd name this "query form" or "query expansion" (the boost is a single exponent) For sure my +1 for you to merge and make it the default. I wonder if there's a hope to disable the Lucene plugin one day since probably many elaborate infrastructures have come to rely on it. paul Le 5 nov. 2012 à 12:27, Eduard Moraru a écrit : > I`ve also attached a few screenshots to the original jira issue if anybody > is interested. > > Please see http://jira.xwiki.org/browse/XWIKI-5676 > > Thanks, > Eduard > > > On Mon, Nov 5, 2012 at 12:49 PM, Ecaterina Moraru (Valica) < > [email protected]> wrote: > >> +1 >> I've played a bit with it and looks really nice (especially the highlight >> feature and the ability to filter) >> >> Thanks, >> Caty >> >> On Mon, Nov 5, 2012 at 12:35 PM, Jerome Velociter <[email protected] >>> wrote: >> >>> Hi Edy, >>> >>> This is great. I've seen you've fixed the lock issue ; I have had that >>> issue when working on the 4.0 branch, I will merge it there and test the >>> migration. In any case I would like to continue this migration as my time >>> allows. My objective is to play with the new spatial submodule (which is >>> also integrated in solr as I understand) and try and contribute a >> "LatLon" >>> XClass property type. >>> >>> +1 for going forward with Solr, >>> >>> Jerome >>> >>> >>> On 11/05/2012 11:26 AM, Eduard Moraru wrote: >>> >>>> Hi devs, >>>> >>>> I would like your vote on merging the 'feature-solr-search' branch with >>>> 'master' for 4.3M2 as planned in the Roadmap. >>>> >>>> Merge Notes: >>>> - A first version of the Solr search is bundled by default as >> experimental >>>> with XE, but Lucene is still the default search engine. >>>> --- Lucene has been upgraded to 3.6.1 [1] and Solr has been downgraded >> to >>>> the same (3.6.1) version in order to achieve the peaceful cohabitation >>>> between the 2 search versions. If we want Solr 4.0, we need to work a >> bit >>>> more on the Lucene search, since Lucene 4.0 comes with a considerable >>>> number of refactorings. >>>> ----- I have just noticed Jerome's feature-lucene-4.0.0-upgrade [2] >>>> branch. >>>> - The admin needs to use the Search Administration to switch from Lucene >>>> to >>>> Solr and back. (each engine has its own index) >>>> - The back-end contains a SolrIndex for add/delete operations and a >>>> QueryExecutor to query the index trough XWiki's Query API using the >> 'solr' >>>> language. >>>> - Indexing is only manually performed for now, from the Search >>>> Administration, blocking the request until the operation is complete. >>>> - Search highlighting is available >>>> - The default search looks only for Documents. Filtered/Advanced search >>>> options can be used to change some of the search parameters. >>>> - Lucene/Solr syntax is supported in the query string >>>> - Faceted search is currently hidden because it is not yet in an usable >>>> state. >>>> - SearchSuggest is still using Lucene, no matter what the configuration >> in >>>> Search Administration says >>>> - The merge also contains a fix for a pretty nasty yet easily fixable >>>> Lucene deadlock [3] (introduced 10 months ago) and some Search Admin UI >>>> improvements [4] >>>> >>>> The pull requests [5][6] are available for reviewing so start shooting >> :) >>>> >>>> Thanks, >>>> Eduard >>>> >>>> ---------- >>>> [1] http://jira.xwiki.org/browse/**XWIKI-8407< >> http://jira.xwiki.org/browse/XWIKI-8407> >>>> [2] >>>> https://github.com/xwiki/**xwiki-platform/tree/feature-** >>>> lucene-4.0.0-upgrade< >> https://github.com/xwiki/xwiki-platform/tree/feature-lucene-4.0.0-upgrade> >>>> [3] http://jira.xwiki.org/browse/**XWIKI-8406< >> http://jira.xwiki.org/browse/XWIKI-8406> >>>> [4] http://jira.xwiki.org/browse/**XWIKI-8408< >> http://jira.xwiki.org/browse/XWIKI-8408> >>>> [5] https://github.com/xwiki/**xwiki-platform/pull/73< >> https://github.com/xwiki/xwiki-platform/pull/73> >>>> [6] https://github.com/xwiki/**xwiki-enterprise/pull/34< >> https://github.com/xwiki/xwiki-enterprise/pull/34> >>>> ______________________________**_________________ >>>> devs mailing list >>>> [email protected] >>>> http://lists.xwiki.org/**mailman/listinfo/devs< >> http://lists.xwiki.org/mailman/listinfo/devs> >>>> >>> >>> ______________________________**_________________ >>> devs mailing list >>> [email protected] >>> http://lists.xwiki.org/**mailman/listinfo/devs< >> http://lists.xwiki.org/mailman/listinfo/devs> >>> >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs >> > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
