Hi, These guidelines are ok assuming the tests are only run once before clearing the database as the CI server does. There are a couple of tests which generate randomly named documents and if you run the test suite multiple times without clearing the database, eventually they build up and cause a registration test to fail. I think it's wrong to leave randomly named garbage in the wiki because it has an inherent collision risk and increases the overall entropy of the tests which we want to avoid.
What I most disagree about is that this test is inherently broken because it doesn't use page objects, it's about 10 lines of code and it's worked up until now. IMO page objects are a tool, if you don't like something because it doesn't use that tool, that's a personal preference. So -0 to tests naming documents using the random number generator. Thanks, Caleb On 11/12/2012 04:02 AM, Vincent Massol wrote: > > On Nov 12, 2012, at 9:56 AM, Sorin Burjan <[email protected]> wrote: > >> Hello Vincent, >> >> I agree with your proposals. I was thinking this is already a rule, >> especially 1) and 2) > > yes me too but since I was having a discussion with Caleb on IRC this morning > and he didn't fully agree about it, I'm resending it as an official vote (I > don't think it ever made it as a proper vote, more something we were doing > "unofficially"). > > Thanks > -Vincent > >> I agree with them. >> >> Regards, >> Sorin B. >> >> >> On Mon, Nov 12, 2012 at 10:50 AM, Vincent Massol <[email protected]> wrote: >> >>> Hi devs, >>> >>> I've just added 3 items on >>> http://dev.xwiki.org/xwiki/bin/view/Community/Testing#HSelenium2-basedFrameworkand >>> I'd like to ensure that we agree about them (if not I'll remove them): >>> >>> * Tests must not depend on one another. In other words, it should be >>> possible to execute tests in any order and running only one test class >>> should work fine. >>> * Test chat need to change existing configuration (e.g. change the default >>> language, set specific rights, etc) must put back the configuration as it >>> was >>> * Tests are allowed to create new documents and don't need to remove them >>> at the end of the test >>> >>> Here's my +1 >>> >>> Thanks >>> -Vincent >>> _______________________________________________ >>> devs mailing list >>> [email protected] >>> http://lists.xwiki.org/mailman/listinfo/devs >>> >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
