+1

On Tue, Jan 22, 2013 at 10:51 AM, Denis Gervalle <[email protected]> wrote:
> Hi devs,
>
> I am currently working on XWIKI-8718 (
> http://jira.xwiki.org/browse/XWIKI-8718) to improve the reporting of failed
> or missing migration directly in the  error reported by the browser. To do
> so, I keep a cache of the exceptions generated by migrations, and reattach
> them to all access failure to a given database. This will really help the
> end user, since it is no more necessary to dig the logs to notice a
> duplicate key issue in a migration.
>
> However, during a simple initial request to XWiki, a lot of access is done
> to the database, and many of them are not fatal (especially in a farm with
> a valid main wiki), but reports warnings or errors to stdout. This produce
> between 5K (main wiki had failed) to 22K lines (a subwiki has failed).
>
> Most of them are caused while getting a value in preference of user, space
> or wiki. And since these are linked together, in a fallback manner, getting
> a user preferences cause three error reports and space two.
>
> Currently these errors are logged at WARN level. Since all these are not
> fatal, and provide correct fallbacks for the current situation, I would
> like to reduce that log level to DEBUG. Doing so will significantly
> simplify the logs (around 2K lines), and avoid really repetitive reports,
> since each access to a single value of the preferences are reported
> individually.
>
> Here is my +1 to reduce to DEBUG, the log level of:
> XWiki#getUserPreference(String prefname, XWikiContext context)
> XWiki#getSpacePreference(String preference, String space, String
> defaultValue, XWikiContext context)
> XWiki#getXWikiPreference(String prefname, String fallback_param, String
> default_value, XWikiContext context)
>
> WDYT ?
>
> --
> Denis Gervalle
> SOFTEC sa - CEO
> eGuilde sarl - CTO
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs



-- 
Thomas Mortagne
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to