On Mar 9, 2013, at 4:40 PM, Vincent Massol <[email protected]> wrote:
> > On Mar 8, 2013, at 6:45 PM, Sergiu Dumitriu <[email protected]> wrote: > >> On 03/08/2013 12:27 PM, Vincent Massol wrote: >>> Hi devs, >>> >>> I'm wondering where to move the AttachmentSelector.xml page which is >>> currently in enterprise-ui >>> >>> It's used by the admin app (XWikiSkinsSheet.xml) and the user app >>> (XWikiUserSheet.xml). >>> >>> Maybe we'll need an attachment module in platform one day and thus we could >>> put it in: >>> xwiki-platform-attachment/xwiki-platform-attachment-ui >>> >>> Another idea is xwiki-platform-model/xwiki-platform-model-ui >>> >>> WDYT? Any other idea? >> >> attachment-ui sounds like a good idea. A dedicated attachments module >> makes it easy to decide that attachments are something optional, not >> embedded in the core model. >> >> model-ui not so good, since to me the model is something more abstract, >> entities that contain data. The attachment picker can be used in may >> places, in many ways, and it's not always about managing attachment, but >> managing other types of fields that just rely on attachments. >> >> Another option would be a catch-all macros module, but I don't like that >> one too much either, since it's encouraging a disorganized macro soup. >> Every macro should have a well defined purpose, in a well defined module. >> >> So, +1 for xwiki-platform-attachment/xwiki-platform-attachment-ui > > ok I've done that locally… Cannot commit yet since I'm going down the rabbit > hole… not sure I'll be able to come out, I hope so since I have already a > lot of changes/clean up… Was able to get out, took me time! :) -Vincent > Thanks > -Vincent > >>> Thanks >>> -Vincent >>> >>> PS: I've started moving UserProfileTest by creating a new >>> xwiki-platform-user-test module when realizing that it depends on the >>> attachmentselector macro… Note that we already have an Admin app page >>> (XWikiSkinsSheet.xml) in xwiki-platform-administration-ui that depends on >>> that macro too so we really need to move AttachmentSelector.xml to platform >>> somewhere... > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
