On Thu, Aug 29, 2013 at 3:01 PM, Clemens Klein-Robbenhaar
<[email protected]> wrote:
> On 08/29/2013 02:25 PM, Thomas Mortagne wrote:
>> On Thu, Aug 29, 2013 at 1:39 PM, Thomas Mortagne
>> <[email protected]> wrote:
>>> On Thu, Aug 29, 2013 at 12:23 PM, Clemens Klein-Robbenhaar
>>> <[email protected]> wrote:
>>>>
>>>> Yes, I see it is fixed, thanks!
>>>> Now it is easier for me to see which translations are missing.
>>>>
>>>> One small point: it seems the "repair" process did not remove
>>>> "wrong" deprecation keys like here:
>>>>  
>>>> http://l10n.xwiki.org/xwiki/bin/inline/Platform/PlatformXWikiCoreResources_-1260871922_annotations-title_de
>>>> however these are not that read and taken onto account,
>>>> so it is not really a problems
>>>
>>> I just repaired the wrong copies actually, the next update of the
>>> importer will take care of refreshing the metadatas.
>>
>> I have just forced one, lets see.
>>
>
> The "deprecation key" is now gone, however the "Deprecated" flag is still 
> set; e.g.:
> http://l10n.xwiki.org/xwiki/bin/inline/Platform/PlatformXWikiCoreResources_-1260871922_annotations-title_de

This one is deprecated. The right one is on
http://l10n.xwiki.org/xwiki/bin/inline/Platform/PlatformAnnotationCodeTranslations_-1260871922_annotations-title_de.
Moved from oldcore to annotation module.

>
> not sure if this really makes a difference, the normal serach does not allow 
> to exclude
> deprecated keys, (and it should not do so IMO) so I have no problems with 
> that little issue
>
>>>
>>>>
>>>> Cheers,
>>>> Clemens
>>>>
>>>>
>>>> On 08/29/2013 11:15 AM, Thomas Mortagne wrote:
>>>>> The importer should be OK now and I also cleaned the mistake of the
>>>>> previous one. Note that the only broken translations were the one
>>>>> without any translation as far as I can see.
>>>>>
>>>>> Thanks for the report !
>>>>>
>>>>> On Thu, Aug 22, 2013 at 4:18 PM, Clemens Klein-Robbenhaar
>>>>> <[email protected]> wrote:
>>>>>> Hi Marius,
>>>>>>
>>>>>>  issue created at http://jira.xwiki.org/browse/XINFRA-94
>>>>>>
>>>>>> Thanks,
>>>>>> Clemens
>>>>>>
>>>>>> On 08/22/2013 03:37 PM, Marius Dumitru Florea wrote:
>>>>>>> Hi Clemens,
>>>>>>>
>>>>>>> Can you report an issue on
>>>>>>> http://jira.xwiki.org/browse/XINFRA/component/12646 ? It looks like
>>>>>>> the
>>>>>>>
>>>>>>> #@deprecated some.new.translation.key
>>>>>>>
>>>>>>> comment is applied to all the following keys until the next
>>>>>>> deprecation comment. Instead it should target only the following key.
>>>>>>> In your example
>>>>>>>
>>>>>>> #@deprecated platform.extension.updater.reloadHint
>>>>>>>
>>>>>>> is followed by a bunch of translation keys for the annotation module
>>>>>>> that have been removed and they all get
>>>>>>> 'platform.extension.updater.reloadHint' as new key..
>>>>>>>
>>>>>>> Thanks for catching this,
>>>>>>> Marius
>>>>>>>
>>>>>> _______________________________________________
>>>>>> devs mailing list
>>>>>> [email protected]
>>>>>> http://lists.xwiki.org/mailman/listinfo/devs
>>>>>
>>>>>
>>>>>
>
>>>
>>> --
>>> Thomas Mortagne
>>
>>
>>
>
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs



-- 
Thomas Mortagne
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to