Great job indeed. I installed on a test wiki on a 4.5 farm and it looks quite nice.
I have a few questions. 1/ If I understand properly we have a legacy.css where lives all CSS of HTML that would not have been made clean plain bootstrap compatible HTML. Is that so ? 2/ In terms of work, how much and what is needed to get to a point where this could become our default skin, knowing that we should not have feature regression, for instance users should still be able to build their color themes in Wysiwyg like they can with colibri. I'm sure we can find a solution to do on the fly compiling when saving color themes so to solve the issue of needing LESS. 3/ How much is needed to get rid of legacy and have a fully native skin with the new system ? 4/ What is the migration path for a wiki where a custom skin has been built on colibri 5/ What are the potential consequences on future compatibility with colibri based skin, particularly if we start modifying our HTML produced by different modules ? Ludovic 2013/9/20 Ecaterina Moraru (Valica) <[email protected]> > Hi devs, > > For the past weeks I've been working on a skin based on Bootstrap[1]. You > can read more about it and test the new Junco Skin at > http://extensions.xwiki.org/xwiki/bin/view/Extension/Junco+Skin > > This proposal is about using the Junco Skin (Blueberry > Theme< > http://extensions.xwiki.org/xwiki/bin/view/Extension/Junco+Skin#HTheme:Blueberry > >) > for xwiki.org. > I prepared some responsive screenshots for the xwiki.org Homepage and an > Extension page. > > http://incubator.myxwiki.org/xwiki/bin/view/Improvements/XWikiOrgJuncoHomepage > > This is my +1 > > Please report any issues on https://github.com/evalica/bootswatch/issues > > __Advantages__ > - a change is always welcomed, shows the users there is activity on the > website; > - the skin is responsive; > - by using Bootstrap we have the whole framework's power to use (grids, > components, etc.); > - we have the chance to test a bit the skin in production and see the > possible bugs, in order to later integrate; > - IMO the skin looks nice :) > > __Disadvantages__ > - the only disadvantage is that there will be bugs and they will take some > time to be detected and fixed; > > __Platform integration problems__ > 1. currently the new skin uses the HTML5 doctype. This is needed if we were > to use some Bootstrap JS components (carousel, menus, etc.) - which we > currently don't on xwiki.org, so I could use the old doctype (but lose > some > of the testing purpose). Because of the HTML5 doctype, the HTML validation > fails. See http://jira.xwiki.org/browse/XWIKI-7552 > > 2. Junco Skin currently doesn't have support for changing the ColorThemes > on the fly. I would need the help of a developer to fix this problem. Is > not so much a problem for xwiki.org (I could fix them by duplicating some > code in the xwiki.org skin), but it is a problem for the integration. > > 3. Being build on Bootstrap, it needs LESS to compile the files into CSS. > Again I would need a developer to see how we could integrate the building > of the themes in platform. Right now this is done locally, partially manual > by using Grunt. > > Tell me what you think and take some time to test the skin, > Caty > > [1] http://getbootstrap.com/ > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Ludovic Dubost Founder and CEO Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
