FTR I've now moved all ScriptService except for DistributionScriptService which is not supposed to be public according to Thomas.
I've also added a custom checkstyle rule. It would be nice that all devs verify the ScriptService they have implemented to ensure that they have @Unstable if they've been added recently and require it (I did a quick pass on them already). Thanks -Vincent On Sep 19, 2013, at 8:33 PM, Vincent Massol <[email protected]> wrote: > > On Sep 19, 2013, at 8:21 PM, Sergiu Dumitriu <[email protected]> wrote: > >> On 09/19/2013 02:00 PM, Vincent Massol wrote: >>> The VOTE is passed with 4 +1, no 0 and no -1. >>> >>> Created http://jira.xwiki.org/browse/XWIKI-9482 and planning it for 5.3M1 >> >> How about: >> >> org.xwiki.<module> - the real APIs >> org.xwiki.<module>.internal - the implementation >> org.xwiki.<module>.script - the script service >> >> This way the script service is not internal, but it's not mixed with the >> APIs so that it's more clear that it's not supposed to be used from >> other java classes. > > Sounds good to me! We already put the SS in the script package in a few > places. > > Thanks > -Vincent > >>> Thanks >>> -Vincent >>> >>> On May 21, 2013, at 12:10 PM, Vincent Massol <[email protected]> wrote: >>> >>>> Hi devs, >>>> >>>> We need to solve http://jira.xwiki.org/browse/XWIKI-9157 >>>> >>>> I'm proposing to simply move all ScriptService implementations out of the >>>> internal package and make that a rule. >>>> >>>> These classes are used by introspection and as such as not used as >>>> components and thus they should not be in the internal package. >>>> >>>> Here's my +1 and I'm proposing to handle the move. >>>> >>>> I can't think of anything that would break except some users who would >>>> have had an import in a groovy script on some internal Script Service but >>>> that's ok IMO. >>>> >>>> Thanks >>>> -Vincent >>>> >> >> >> -- >> Sergiu Dumitriu >> http://purl.org/net/sergiu >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
