Guys, I didn't pay enough attention to this topic (thus my +0) but what we did is very bad! I used myself $services.wikimanager in lots of places and I'm sure others have used it also (especially since we moved to virtual mode on by default) so we cannot simply remove an API like this. This is not different than removing a method or a class from a public API (which would be caught by CLIRR). We need to apply the same deprecation strategy: mark $services.wikimanager as deprecated, move to legacy, log warning messages when it is used, update all places in platform where it is currently used, etc.
I just found out that the Wiki search facet isn't displayed as I advertised it in the release notes of 5.3M2 http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/ReleaseNotesXWiki53M2#HSearchFacets because the Wiki Manager API has been removed https://github.com/xwiki/xwiki-enterprise/commit/b8fcbc7267ff587807698b4afd745f7c3f81e0ae#diff-0 after I closed my issue http://jira.xwiki.org/browse/XWIKI-9613 .. We need ensure that the public API of Wiki Manager (e.g. the script service) is still available. It can wrap the new API or it can do what it currently does but it has to remain available. Thanks, Marius On Thu, Nov 14, 2013 at 5:56 PM, Marius Dumitru Florea <[email protected]> wrote: > +0 > > Thanks, > Marius > > On Wed, Nov 13, 2013 at 6:45 PM, Guillaume "Louis-Marie" Delhumeau > <[email protected]> wrote: >> Hi devs. >> >> Thomas has merged my pull request for the new wiki API. I'm happy! >> >> Now, xwiki-platform-wiki-manager and xwiki-platform-workspaces are >> obsoletes. We should delete them or move them to xwiki-contrib. >> >> Here is my +1 for the move! >> >> Thanks >> Louis-Marie >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
