+1 I had never agreed with that change, only with the removal of the syntax in the default list of available syntax. By the way, do not forget to adapt the comments in the configuration as well, to reintroduce the syntax there (in comments only, of course).
On Fri, Mar 21, 2014 at 9:35 AM, Thomas Mortagne <[email protected]>wrote: > +1 > > We have tons of if(syntax==xwiki/1.0), one less would be nice > especially when it's not that useful. > > On Fri, Mar 21, 2014 at 8:52 AM, [email protected] <[email protected]> > wrote: > > Hi devs, > > > > Sergiu implemented http://jira.xwiki.org/browse/XWIKI-8988 a while ago > and I didn't agree with it (see my comment there). > > > > I have 2 arguments: > > 1) Lots of code snippets on e.x.o are still in syntax 1.0 and if you > need to test them you still need to be able to create pages in 1.0 syntax > > 2) We shouldn't hardcode anything and right now we have hardcoded the > knowledge of the xwiki/1.0 syntax in DocumentInformation.xml: > > > > #foreach ($syntax in $availableParserSyntaxes) > > #if ($configuredSyntaxes.contains($syntax.toIdString()) > && !$syntax.toIdString().equalsIgnoreCase('xwiki/1.0')) > > > > The important part for me is that the xwiki/1.0 syntax is NOT enabled by > default in xwiki.cfg and thus users won't use it by mistake. Only those who > really need to use it would be able to use it. > > > > I'd like to reinstate the ability to use xwiki/1.0 syntax in XWiki 5.x > by removing the hardcoded check. > > > > WDYT? > > > > Thanks > > -Vincent > > > > > > _______________________________________________ > > devs mailing list > > [email protected] > > http://lists.xwiki.org/mailman/listinfo/devs > > > > -- > Thomas Mortagne > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
