On Thu, May 22, 2014 at 10:22 AM, walid yaich <[email protected]> wrote: >>I don't agree, changing parameters coming with an event is a breakage. >>There will be new events with the new model and those may not pass the >>XWikiContext but that's all. > > Yep, i didn't change it, not even in my code, thanks :)
I was answering to Sergiu. I'm talking about an event a new version of XWiki changing the parameters send with an event. So not there is absolutely no reason that data is not XWikiContext anytime. > > > 2014-05-22 6:32 GMT+01:00 Thomas Mortagne <[email protected]>: > >> On Wed, May 21, 2014 at 7:47 PM, Sergiu Dumitriu <[email protected]> wrote: >> > On 05/21/2014 01:44 PM, Thomas Mortagne wrote: >> >> On Wed, May 21, 2014 at 7:25 PM, walid yaich <[email protected]> >> wrote: >> >>>>> As I said in the preview mail data is the XWikiContext. >> >>> I'm sorry, i didn't understand exactly what you mean by "data is the >> >>> XWikiContext." >> >> >> >> You are in the following method: >> >> >> >> void onEvent(Event event, Object source, Object data) >> >> >> >> the second parameter is called data in your code and it's already a >> >> XWikiContext object you don't have to do a hack to get it. >> >> >> > >> > Note that the xcontext is sent as the "data" parameter as a convenience, >> > since historically there was no other way of getting hold of it. It is >> > not guaranteed that this will continue to happen. The preferred method >> > is still to access the execution context. >> >> I don't agree, changing parameters coming with an event is a breakage. >> There will be new events with the new model and those may not pass the >> XWikiContext but that's all. >> >> > >> > -- >> > Sergiu Dumitriu >> > http://purl.org/net/sergiu >> > _______________________________________________ >> > devs mailing list >> > [email protected] >> > http://lists.xwiki.org/mailman/listinfo/devs >> >> >> >> -- >> Thomas Mortagne >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs >> > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
