I have not read all of the code but I'm +1 to the principle, including the skin action change which makes logical sense. Are you planning on pushing this into 6.1M2 ?
Thanks, Caleb On 06/11/2014 05:43 PM, Guillaume "Louis-Marie" Delhumeau wrote: > Hi devs. > > I am implementing the Color Theme Editor for Flamingo! And this is a > preview: > http://design.xwiki.org/xwiki/bin/download/Proposal/ColorThemeforFlamingo/flamingo-theme-editor.png > > Since the current color theme application is strongly linked to Colibri, > and the new application will be strongly linked to Flamingo, I propose the > following: > > 1/ move xwiki-platform-colorthemes in xwiki-platform-colibri and state that > this application is only compatible with colibri-based skin. > 2/ create the new application in xwiki-platform-flamingo > 3/ the new color theme application will actually propose more than colors > (fonts, less code, etc...), so I propose to call it > xwiki-platform-flamingo-themes. > 4/ in the administration, we have a page that propose which color theme we > want to use. Since the new application will not be compatible with the old > one, I propose to add an extension point (such as what we have to configure > search suggest sources) in order to propose the themes corresponding to the > selected skin (ie: xobjects of ColorThemes.ColorThemeClass for colibri and > skins based on colibri, and xobjects of FlamingoThemeCode.ThemeClass for > flamingo). > 5/ modify SkinAction that currenlty executes velocity code on a skin file > if the mime type is CSS or JS, to also execute velocity on files suffixed > by .less.vm, because I need it for my application. To see what it looks > like, please look at > https://github.com/gdelhumeau/xwiki-platform/commit/49aca5733f4a820f3d1327c76a7229781886dddf#diff-114 > . The alternative is to create a new action which is too much IMO. > 6/ when colibri will be deprecated on removed from XE, we will do the same > for the old color theme application. > > WDYT? > > Thanks, > Guillaume > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
