Hi Vincent, Looks better in general, the only drawback I still see is that you may succeed stop while XWiki is still running. Shouldn't we have a real failure situation ? I mean something like if ps -p `cat $XWIKI_LOCK_FILE` > /dev/null then echo 'Failed to kill XWiki, give up !' exit 1 end And check the return code in the start script to not try to start in that case, and also give up.
Maybe it is overkill, I don't know. WDYT ? On Fri, Sep 12, 2014 at 12:48 AM, [email protected] <[email protected]> wrote: > Hi devs, > > I’ve been working today on new versions of start_xwiki.sh/stop_xwiki.sh. > I’ve modified them to check if xwiki is already running with an option to > stop/kill any already running xwiki instance. > > The rationale is that we need this in our CI for our functional tests in > case XE instances are not stopped (for ex if jenkins master is stopped or > if the ci machine is restarted, leaving agents in a bad state). > > start_xwiki.sh: https://gist.github.com/vmassol/2cf7952d71521d626313 > stop_xwiki.sh: https://gist.github.com/vmassol/7a99f790445094f06ba4 > > Note that I’ve introduced a different way to pass parameters to > start_xwiki.sh (ex: start_xwiki.sh -p 8080 -sp 8079) > > Left to do: > - use bash also for stop_xwiki.sh > - modify stop_xwiki.sh to use the same way to pass parameters than > start_xwiki.sh > - modify *_xwiki_debug.sh too > > WDYT? > > Thanks > -Vincent > > > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
