On Wed, Oct 1, 2014 at 5:43 PM, Ecaterina Moraru (Valica) <[email protected]> wrote: > On Wed, Oct 1, 2014 at 6:02 PM, Guillaume "Louis-Marie" Delhumeau < > [email protected]> wrote: > >> 2014-10-01 16:41 GMT+02:00 Ecaterina Moraru (Valica) <[email protected]>: >> >> > Hi, >> > >> > IMO /templates/ folder makes sense when there are multiple skins >> supported. >> > Now that Colibri is not the default skin anymore, we should copy all the >> > templates specific to Colibri in /colibri/ folder. >> > Flamingo should contain just templates specific to it. >> > >> > /templates/ should contain templates shared both by Colibri and Flamingo. >> > >> > When we are going to deprecate Colibri, in the deprecation step we should >> > copy the whole content of /templates/ and add it in Colibri, than move it >> > to contrib. >> > >> > In the close future we might need to have multiple skins depending on the >> > Flavor. This means we might use the templates folder much more (and >> Colibri >> > will be deprecated in the meanwhile) because the new skins will probably >> > fallback on the Flamingo skin. >> > >> >> Actually, if a new skin has "Flamingo" as "base skin", then it will >> failback to "flamingo" files anyway. We don't need the "templates" dir to >> achieve that. >> > > How do we set 'base skin' at filesystem level? If we were to have multiple > skins for Groupware, Public Website, etc. Flavors, and we implement them as > file system skins, how do you make them fallback on the common templates? >
All filesystem skins inherit from the skin set as xwiki.defaultBaseSkin in xwiki.cfg. > Thanks, > Caty > > >> >> >> > This means, when we deprecate Colibri we will need to copy all the >> > templates from Flamingo and move them to /templates. When new skins >> appear >> > we take the specific templates and put them in the desired skin folder >> > while keeping the common templates in templates/. etc.etc.etc. >> > >> > This is the way we worked until now with the skins we had: albatross, >> > toucan, colibri. >> > >> > Thanks, >> > Caty >> > >> > >> > >> > >> > >> > >> > On Wed, Oct 1, 2014 at 4:51 PM, Thomas Mortagne < >> [email protected] >> > > >> > wrote: >> > >> > > The location of this folder only make sense when it contains only >> > > generic content. All skins inherit from it and having Flamingo inherit >> > > from a partial Colibri (which is the current situation) does not make >> > > any sense. >> > > >> > > Having this folder not containing much is not an issue but having it >> > > filled with what is specific to a skin does not make any sense. Why >> > > bother even having a separated project for the skin in that case ? >> > > >> > > On Wed, Oct 1, 2014 at 2:42 PM, Guillaume "Louis-Marie" Delhumeau >> > > <[email protected]> wrote: >> > > > Hi. >> > > > >> > > > Since 6.2, we have the following issue: >> > > > http://jira.xwiki.org/browse/XWIKI-11027 "The templates directory >> has >> > > VMs >> > > > from Colibri". >> > > > >> > > > Until now, we used to have all *.vm files in this directory, and >> > nothing >> > > in >> > > > the "colibri" one, because Colibri was the default skin. >> > > > >> > > > Now that Flamingo is the default skin, we have to decide what we do >> > with >> > > > this directory. Should we move all Flamingo's files in that >> directory? >> > > > Should we only put the files that Colibri & Flamingo have in common? >> I >> > > have >> > > > reported a list of problems that these decisions make, on the Jira. >> > > > >> > > > Actually, the "templates" directory seems to mean that we should put >> > only >> > > > "generic" templates. But what does it mean? Most of the files depends >> > on >> > > > the skin, so they are not generic. Except some files for the >> > Distribution >> > > > Wizard that should not be skin-dependent. >> > > > >> > > > What do you think about it? >> > > > >> > > > Thanks, >> > > > >> > > > -- >> > > > Guillaume Delhumeau ([email protected]) >> > > > Research & Development Engineer at XWiki SAS >> > > > Committer on the XWiki.org project >> > > > _______________________________________________ >> > > > devs mailing list >> > > > [email protected] >> > > > http://lists.xwiki.org/mailman/listinfo/devs >> > > >> > > >> > > >> > > -- >> > > Thomas Mortagne >> > > _______________________________________________ >> > > devs mailing list >> > > [email protected] >> > > http://lists.xwiki.org/mailman/listinfo/devs >> > > >> > _______________________________________________ >> > devs mailing list >> > [email protected] >> > http://lists.xwiki.org/mailman/listinfo/devs >> > >> >> >> >> -- >> Guillaume Delhumeau ([email protected]) >> Research & Development Engineer at XWiki SAS >> Committer on the XWiki.org project >> _______________________________________________ >> devs mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/devs >> > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs -- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
