Hi Eddy

2014-10-07 22:53 GMT+02:00 Eduard Moraru <[email protected]>:

> Hi Guillaume,
>
> What about XWiki.currentWiki/Space/page values and even
> XWiki.currentDocument? You plan to replace the with your JS service?
>

These values are directly set in the HTML of the page, which is not a good
practice, according to Sergiu:
http://markmail.org/message/ffriz3sfl2t3xwts
I don't plan to remove them from:
https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/src/main/resources/flamingo/javascript.vm#L139
for retro-compatibility but we should add a comment to deprecated them.

Actually, we could also add these variables manually in the XWiki object in
compatibility.js if we want to clean this situation.


>
> AFAIK extensions already use these values from the DOM and I don`t see why
> we should change that.

Maybe I did not understand well your intent.
>
> Thanks,
> Eduard
>

Thanks,
Guillaume
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to