On 16 Feb 2015 at 10:14:08, GitHub ([email protected](mailto:[email protected])) wrote:
> Branch: refs/heads/stable-6.4.x > Home: https://github.com/xwiki/xwiki-platform > Commit: 645089e5e573d23868077c96c2edce4d4f2daaa7 > https://github.com/xwiki/xwiki-platform/commit/645089e5e573d23868077c96c2edce4d4f2daaa7 > Author: Marius Dumitru Florea > Date: 2015-02-16 (Mon, 16 Feb 2015) > > Changed paths: > M > xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-macro/pom.xml > > Log Message: > ----------- > XWIKI-11794: 13 smartclient JS files not found when editing a dashboard inline > * Reduce a bit the expected test coverage ratio to fix the quality build. I > find it silly that removing a few lines of code from a method that has unit > tests can lower the ratio (there are less instructions tested but there are > less instructions in total also). Not sure what you find silly because if some code is more tested than the rest of the code in the same module and if you remove that code (and thus the tests too), then it’s obvious that you will reduce the TPC (it’s a percentage). Maybe you have a wrong perception of what the TPC is? You seem to be wanting some fixed value (and not a percentage) but that doesn’t exist :) Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
