On Wed, Mar 18, 2015 at 11:11 PM, Jean SIMARD <[email protected]> wrote:
> Hi Caty and devs,
>
> We could not change the name of the package and only encapsulate it in a
> parent POM ('application-forum-package' or 'application-forum-extension'
> or something else) like the following.
>
and why not more explicitly application-forum-parent :)
I done so for the farm-tools application, and found this not that bad,
since this package is never shown or installed, it is just a parent for
building after all.
>
> application-forum-package/
> + pom.xml
> + application-forum/
> | + pom.xml
> | + src/
> + application-forum-test/
> | + pom.xml
> | + application-forum-test-pageobjects/
> | | + pom.xml
> | | + src/
> | + application-forum-test-tests/
> | | + pom.xml
> | | + src/
>
> What do you think? Of course, it doesn't solve the problem of
> homogenization of application's names.
>
> On 18/03/2015 19:28, Ecaterina Moraru (Valica) wrote:
> > Hi,
> >
> > I want to write automated tests for some contrib applications, but I need
> > you help on some questions.
> >
> > == Prb 1. Folder Structure + Changing IDs ==
> >
> > Currently the majority of applications don't have modules.
> >
> > Also some applications have IDs that don't correspond with the contrib
> > standard: sometimes wrong groupId like 'org.xwiki.contrib.forum',
> sometimes
> > random artifactId.
> >
> > When wanting to change the groupId for 'org.xwiki.contrib.forum' I was
> told
> > that we should change it only if we have a very good reason, otherwise
> > changing the ID will resolve in upgrading problems within the Extension
> > Manager. Unfortunately I don't remember exactly the problem with the
> > changing of the ID, I just know I don't need to do it :) (//sorry Thomas)
> >
> > Example: https://github.com/xwiki-contrib/application-forum
> > Theoretically, wanting to add tests I would need to create two modules:
> > - application-forum-test
> > - application-forum-ui, and move the current sources here.
> > Unfortunately this means a change in the ID.
> >
> > Are 'adding tests' a good reason to change the ID?
> > Should I not change the ID, and just add a test module?
> > - application-forum-test
> > - src/main/resources
> >
> > == Prb 2. Naming standards ==
> >
> > We have some conventions on contrib.xwiki.org about name of the project.
> > We should add maybe some more examples on groupId and artifactId.
> >
> > Also when looking at the test modules names, some applications have:
> > - {{full-repository-name}}-tests
> > - {{full-repository-name}}-test
> > - {{partial-repository-name}}-test
> > - {{random-repository-name}}-test
> > - test
> >
> > Maybe we should agree also on this and document it.
> > I guess the correct name would be:
> > - {{full-repository-name}}-test
> > -- {{full-repository-name}}-test-pageobjects
> > -- {{full-repository-name}}-test-tests
> > - {{full-repository-name}}-ui
> >
> > Also if we are 'discovering' some applications that don't correspond to
> the
> > standard, do we change them or do we let them be? Since changing means a
> > change in the ID :P
> >
> > Since in theory we should have automated tests for all our applications,
> > should we add a convention to always create a
> > - {{full-repository-name}}-ui ?
> >
> > Additional question: Also when we will transfer from platform to contrib,
> > are we going to rename the modules?
> >
> > Thanks,
> > Caty
> > _______________________________________________
> > devs mailing list
> > [email protected]
> > http://lists.xwiki.org/mailman/listinfo/devs
> >
>
> --
> Jean Simard
> [email protected]
> Research engineer at XWiki SAS
> http://www.xwiki.com
> Committer on the XWiki.org project
> http://www.xwiki.org
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
>
--
Denis Gervalle
SOFTEC sa - CEO
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs
