bump. Please see the discussion in the comments of http://jira.xwiki.org/browse/XWIKI-9292
WDYT? Thanks, Eduard On Thu, Apr 30, 2015 at 6:04 PM, Thomas Mortagne <[email protected]> wrote: > By the way one consequence of this bug is that any user can break a > page that need programming right just by tagging it for the first > time, see http://jira.xwiki.org/browse/XWIKI-9292. > > On Thu, Apr 30, 2015 at 5:02 PM, Thomas Mortagne > <[email protected]> wrote: > > In other words +1 to fix it :) > > > > On Thu, Apr 30, 2015 at 5:02 PM, Thomas Mortagne > > <[email protected]> wrote: > >> On Thu, Jun 13, 2013 at 5:26 PM, Anca Luca <[email protected]> wrote: > >>> Hi Vincent, > >>> > >>> On 06/13/2013 11:08 AM, Vincent Massol wrote: > >>>> > >>>> Hi, > >>>> > >>>> According to the javadoc in XWikiDocument: > >>>> > >>>> /** > >>>> * The last user that has changed the document's content (ie not > >>>> object, attachments). The Content author is only > >>>> * changed when the document content changes. Note that Content > >>>> Author is used to check programming rights on a > >>>> * document and this is the reason we need to know the last > author > >>>> who's modified the content since programming > >>>> * rights depend on this. > >>>> */ > >>>> private DocumentReference contentAuthorReference; > >>>> > >>>> This means that objectadd or objectremove actions shouldn't change the > >>>> content author as they do now. > >>> > >>> > >>> this would mean add and remove object, but not update. Still, the > subject of > >>> the mail mentions object update as well. Which one is it? > >>> > >>>> > >>>> I'm proposing that we fix this. > >>>> > >>>> Do you see any issue? > >>> > >>> > >>> I can think of some documents that need programming rights and for > which the > >>> code that needs the programming rights is in objects: Wiki Macros, > Scheduler > >>> Jobs, JSX/SSX with use "always". This would sort of mean that one can > edit a > >>> wiki macro script and the macro would still have PR, no? > >>> Also, it could be a bit hard to understand why you need to edit the > object > >>> and then go edit the document in wiki mode and save it with no change > (btw, > >>> does that still change document author? I think there was a change > >>> recently...) so that the script you wrote when editing the document in > >>> inline mode still works. > >> > >> Actually this is not true for wiki macros since we use the author for > >> those and not the content author. We could fix the other places too. > >> > >> Having the content author modified when you add an object does not > >> make any kind of sense, the fact that some features badly use it does > >> not make it right. Also since modifying an object does not touch the > >> content author it makes it totally inconsistent. > >> > >>> > >>> Anca > >>> > >>> > >>> > >>>> > >>>> Thanks > >>>> -Vincent > >>>> > >>>> _______________________________________________ > >>>> devs mailing list > >>>> [email protected] > >>>> http://lists.xwiki.org/mailman/listinfo/devs > >>> > >>> > >>> _______________________________________________ > >>> devs mailing list > >>> [email protected] > >>> http://lists.xwiki.org/mailman/listinfo/devs > >> > >> > >> > >> -- > >> Thomas Mortagne > > > > > > > > -- > > Thomas Mortagne > > > > -- > Thomas Mortagne > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
