Hi Yacine. Thanks for publishing your idea.
I don't understand the need for the "Customized Variables" panel. We can already create new variables in the "lessCode" field without declaring it before in the theme editor. The only benefit I can see is that these variables would be taken into account in the live preview, which is currently not the case. It's a good benefit, but limited to the variables that the skin already uses but without being exposed in the editor. About the ability to add some JavaScript code in the theme, I have mixed feelings. Why do you need this ability in the theme? It should be more useful in the skin actually, don't you think? During the last seminar, we had a discussion about what should be a skin and what should be a theme. Both notions are not clearly separated right now. The conclusion was that we should put our modifications in the skin, and use the themes only when it's simple variation of the user interface (colors, fonts). I am pretty sure that a JavaScript field would not be used for these simple variations, but to add new behaviours, to create a new user experience. In that case, it's more the role of a skin. What do you think about this? Thanks, 2015-07-27 18:55 GMT+02:00 Yacine Kebir <[email protected]>: > Hi Devs, > > I would to propose an improvement for the color theme editor to make it > more powerful and flexible. > > In order to achieve this, I propose to > add a new tab "Customized Variables > < > http://design.xwiki.org/xwiki/bin/view/Proposal/Improvethecolorthemeeditor > >" > to the editor. This tab would allow us to add more LESS CSS variables and > list them in a list We could use this variable in order to add more LESS > css rules in the advanced tab and target any area on the platform. > > http://jira.xwiki.org/browse/XWIKI-12351 > > WDYT? > > > > > -- > *Yacine KEBIR* > Web Designer / Front End Developer > [email protected] > > *Mobile: *+213 550 749 033 > *Web Site : *www.xwiki.com > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
