Hi, I have created https://jira.xwiki.org/browse/XWIKI-12736 for this improvement. Regards,
On Tue, Oct 27, 2015 at 11:37 AM, Guillaume "Louis-Marie" Delhumeau < [email protected]> wrote: > +1 > > 2015-10-26 10:53 GMT+01:00 Thomas Mortagne <[email protected]>: > > > On Wed, Oct 21, 2015 at 10:48 AM, Marius Dumitru Florea > > <[email protected]> wrote: > > > On Wed, Oct 21, 2015 at 11:08 AM, Denis Gervalle <[email protected]> > wrote: > > > > > >> Hi devs, > > >> > > >> It looks like a bug to me, but wiki macro defined for global level in > a > > >> subwiki, are effectively influencing the whole farm. > > > > > > > > > If the wiki macro is saved by a global user that has PR. > > > > > > > > >> I would like to change > > >> that like this: > > >> > > >> * global level macro are registered global only if defined in the > main > > >> wiki > > >> * global and wiki level macro defined in a subwiki are registered at > > wiki > > >> level > > >> > > >> The rationals are: > > >> > > >> * if the same global macro document is deployed on more than one > wiki, > > >> which just means the same extension defining that document is > installed > > on > > >> multiple wiki, maybe in different version, all those macros will be in > > >> conflict, it will not be easy to know which one wins, and even more > > >> difficult to detect the problem in the first place. > > >> > > > > > > This can happen also if two different extensions define a macro with > the > > > same name (in two different documents), but I guess this is less > > probable. > > > > > > > > >> * there is risk (of course limited by the PR), that user of subwiki > > >> influence the behaviors of the whole farm, which IMO is quite opposite > > to > > >> the logical structure, and even the physical storage we are used to. > > >> > > > > > > What do you mean by "user of subwiki"? It can be a global user. > > > > > > > > I agree that subwikis should act as namespaces, and normally you expect > > > something defined in an inner namespace to not be visible in the outer > > > namespace. So +1 > > > > +1 > > > > To be consistent we should apply the same logic to other related use > > cases like translations. > > > > > > > > Thanks, > > > Marius > > > > > > > > >> * I do not see any benefit of putting a global macro in a subwiki > > > > > > > > >> wdyt ? > > >> > > >> -- > > >> Denis Gervalle > > >> SOFTEC sa - CEO > > >> _______________________________________________ > > >> devs mailing list > > >> [email protected] > > >> http://lists.xwiki.org/mailman/listinfo/devs > > >> > > > _______________________________________________ > > > devs mailing list > > > [email protected] > > > http://lists.xwiki.org/mailman/listinfo/devs > > > > > > > > -- > > Thomas Mortagne > > _______________________________________________ > > devs mailing list > > [email protected] > > http://lists.xwiki.org/mailman/listinfo/devs > > > > > > -- > Guillaume Delhumeau ([email protected]) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Denis Gervalle SOFTEC sa - CEO _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
