I've already answered privately to Thomas but I post the answer here too
for the others: both flamingo themes and colibri themes are listed by this
field in the admin UI.

Here a screenshot of the expected behavior:
http://extensions.xwiki.org/xwiki/bin/download/Extension/Flamingo+Theme+Application/ColorThemeDisplayer.png

I think we should keep the requests like this. It fully works and it's
retro-compatible for persons who really want to keep old color themes.


2016-01-12 10:22 GMT+01:00 Thomas Mortagne <[email protected]>:

> How can this field fully work or make sense without color theme
> application since among other thing it means not having color theme
> class ? It will just display whatever string is set but you can't
> really add more color theme or properly edit the existing ones (if
> there is any).
>
> On Tue, Jan 12, 2016 at 9:57 AM, Guillaume "Louis-Marie" Delhumeau
> <[email protected]> wrote:
> > No, because it is used for the Flamingo themes too.
> >
> > 2016-01-11 20:39 GMT+01:00 Thomas Mortagne <[email protected]>:
> >
> >> Does this require to modify the admin UI to remove color theme field ?
> >>
> >> On Mon, Jan 11, 2016 at 6:26 PM, Guillaume "Louis-Marie" Delhumeau
> >> <[email protected]> wrote:
> >> > Caty is right. The color theme editor should be removed in theory. The
> >> > retro-compatibility is supported by 'colorThemeInit.vm' in Flamingo.
> >> >
> >> > However, it will break existing installations that still use an old
> color
> >> > theme with Flamingo. But it's OK as soon as the color theme
> application
> >> is
> >> > installable with EM.
> >> >
> >> > 2016-01-11 18:17 GMT+01:00 Thomas Mortagne <[email protected]
> >:
> >> >
> >> >> On Mon, Jan 11, 2016 at 6:10 PM, Ecaterina Moraru (Valica)
> >> >> <[email protected]> wrote:
> >> >> > Hi,
> >> >> >
> >> >> > So I see that the code has been moved to
> >> >> > https://github.com/xwiki-contrib/skin-colibri
> >> >> >
> >> >> > My questions are:
> >> >> > A. what do we do with ColorThemes
> >> >> >
> >> >>
> >>
> https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwiki-platform-colorthemes
> >> >> > ? since they are build especially for Colibri (although they have
> some
> >> >> > compatibility also for Flamingo).
> >> >>
> >> >> If color theme is not usable with Flamingo then it should be moved to
> >> >> but I have no experience with it so I will let others talk about it
> >> >> and I can apply whatever is decided.
> >> >>
> >> >> > B. What happens to Colibri Skin
> >> >> > https://jira.xwiki.org/browse/XWIKI/component/11214 and
> ColorThemes
> >> >> > https://jira.xwiki.org/browse/XWIKI/component/12542 components?
> >> >> > B1. we could move the issues in dedicated projects in the "XWiki
> >> >> > Contributed Projects" section and leave them open for a while
> >> >> > B2. we could close the issues with a message like "The Colibri skin
> >> is no
> >> >> > longer supported. If you're interested in working on it you can
> find
> >> the
> >> >> > sources in the xwiki-contrib repository on GitHub,
> >> >> > https://github.com/xwiki-contrib/skin-colibri"; and rename the
> >> component
> >> >> > using a {Unused} or {RETIRED} label
> >> >> > B3. we will need to filter the issues a bit to see which of them
> are
> >> >> still
> >> >> > valid for Flamingo.
> >> >>
> >> >> I just forgot, what we always do is close everything (which should
> >> >> have been done before since Colibri was deprecated before the move
> >> >> already) and and put {Unused} so that's what I will do for the
> colibri
> >> >> component.
> >> >>
> >> >> >
> >> >> > Thanks,
> >> >> > Caty
> >> >> >
> >> >> > On Mon, Jan 4, 2016 at 12:33 PM, Ecaterina Moraru (Valica) <
> >> >> > [email protected]> wrote:
> >> >> >
> >> >> >> +1
> >> >> >>
> >> >> >> Thanks,
> >> >> >> Caty
> >> >> >>
> >> >> >> On Mon, Dec 28, 2015 at 9:05 PM, Denis Gervalle <[email protected]>
> >> wrote:
> >> >> >>
> >> >> >>> +1
> >> >> >>>
> >> >> >>> Thanks
> >> >> >>>
> >> >> >>> On Mon, Dec 28, 2015 at 7:17 PM, Eduard Moraru <
> >> [email protected]>
> >> >> >>> wrote:
> >> >> >>>
> >> >> >>> > +1,
> >> >> >>> >
> >> >> >>> > Thanks,
> >> >> >>> > Eduard
> >> >> >>> >
> >> >> >>> > On Sat, Dec 26, 2015 at 7:52 AM, Marius Dumitru Florea <
> >> >> >>> > [email protected]> wrote:
> >> >> >>> >
> >> >> >>> > > +1
> >> >> >>> > >
> >> >> >>> > > Thanks,
> >> >> >>> > > Marius
> >> >> >>> > >
> >> >> >>> > > On Thu, Dec 24, 2015 at 1:12 PM, Thomas Mortagne <
> >> >> >>> > > [email protected]>
> >> >> >>> > > wrote:
> >> >> >>> > >
> >> >> >>> > > > Hi devs,
> >> >> >>> > > >
> >> >> >>> > > > Following http://markmail.org/message/fb2tsh2gwu44xsua
> (Drop
> >> >> >>> support
> >> >> >>> > > > for Colibri Skin in 7.x) I would like to propose to move
> >> colibri
> >> >> to
> >> >> >>> > > > https://github.com/xwiki-contrib/ in 8.0 branch.
> >> >> >>> > > >
> >> >> >>> > > > Here is my +1,
> >> >> >>> > > >
> >> >> >>> > > > --
> >> >> >>> > > > Thomas Mortagne
> >> >> >>> > > > _______________________________________________
> >> >> >>> > > > devs mailing list
> >> >> >>> > > > [email protected]
> >> >> >>> > > > http://lists.xwiki.org/mailman/listinfo/devs
> >> >> >>> > > >
> >> >> >>> > > _______________________________________________
> >> >> >>> > > devs mailing list
> >> >> >>> > > [email protected]
> >> >> >>> > > http://lists.xwiki.org/mailman/listinfo/devs
> >> >> >>> > >
> >> >> >>> > _______________________________________________
> >> >> >>> > devs mailing list
> >> >> >>> > [email protected]
> >> >> >>> > http://lists.xwiki.org/mailman/listinfo/devs
> >> >> >>> >
> >> >> >>>
> >> >> >>>
> >> >> >>>
> >> >> >>> --
> >> >> >>> Denis Gervalle
> >> >> >>> SOFTEC sa - CEO
> >> >> >>> _______________________________________________
> >> >> >>> devs mailing list
> >> >> >>> [email protected]
> >> >> >>> http://lists.xwiki.org/mailman/listinfo/devs
> >> >> >>>
> >> >> >>
> >> >> >>
> >> >> > _______________________________________________
> >> >> > devs mailing list
> >> >> > [email protected]
> >> >> > http://lists.xwiki.org/mailman/listinfo/devs
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Thomas Mortagne
> >> >> _______________________________________________
> >> >> devs mailing list
> >> >> [email protected]
> >> >> http://lists.xwiki.org/mailman/listinfo/devs
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > Guillaume Delhumeau ([email protected])
> >> > Research & Development Engineer at XWiki SAS
> >> > Committer on the XWiki.org project
> >> > _______________________________________________
> >> > devs mailing list
> >> > [email protected]
> >> > http://lists.xwiki.org/mailman/listinfo/devs
> >>
> >>
> >>
> >> --
> >> Thomas Mortagne
> >> _______________________________________________
> >> devs mailing list
> >> [email protected]
> >> http://lists.xwiki.org/mailman/listinfo/devs
> >>
> >
> >
> >
> > --
> > Guillaume Delhumeau ([email protected])
> > Research & Development Engineer at XWiki SAS
> > Committer on the XWiki.org project
> > _______________________________________________
> > devs mailing list
> > [email protected]
> > http://lists.xwiki.org/mailman/listinfo/devs
>
>
>
> --
> Thomas Mortagne
> _______________________________________________
> devs mailing list
> [email protected]
> http://lists.xwiki.org/mailman/listinfo/devs
>



-- 
Guillaume Delhumeau ([email protected])
Research & Development Engineer at XWiki SAS
Committer on the XWiki.org project
_______________________________________________
devs mailing list
[email protected]
http://lists.xwiki.org/mailman/listinfo/devs

Reply via email to