> On 31 Mar 2016, at 13:02, Alexandru Cotiuga <[email protected]> > wrote: > > Hi devs, > > As I was working on the Forum Application, which depends on Ratings > Application, I noticed that the rating configuration doesn't work as > expected on the Nested Spaces versions of XWiki. > > For example, having A.WebPreferences with a XWiki.RatingsConfigClass > object, the configuration does not apply to A.B.WebHome, because the > configuration is set at space level, without inheritance to the below > levels. > > As a solution for this I propose to create a new Api > (getConfigurationDocument()) in the Ratings module which will check, > starting the current document, and get the first ancestor that holds the > XWiki.RatingsConfigClass object and use that as configuration document, > keeping the fallback to the XWiki.RatingsConfig document. > > An issue has been created at http://jira.xwiki.org/browse/XWIKI-13274 and a > first pull request at https://github.com/xwiki/xwiki-platform/pull/472, but > without having been discussed here before. > > WDYT?
Sounds good to me. I gave several comments in the PR. One important one is to introduce a RatingsConfiguration component to hold the Ratings module’s configuration and have the various other Ratings components use it, including the ScriptService since right now there are at least 3 places getting the config. Thanks -Vincent _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
