Hello all, while using the ratings application on an XWiki 6.2.4, we encountered some bugs related to the storage of ratings in a separate space and with the update of a user's rating.
We fixed them in these 2 commits: https://github.com/xwiki-contrib/application-ratings/commit/07758a698d400ed275cde1e6fde4515d41711b40 and https://github.com/xwiki-contrib/application-ratings/commit/cd2c190e22f709e2b55fed19be25ea8ef7631730 . Now, the contrib ratings application was indeed "retired" so we normally should not use the contrib repo anymore. However, the work in these 2 commits is about fixing bugs (which might even be affecting the most recent version of ratings - we need to check that, didn't check it yet), and I don't see exactly what other option we have in this case (note that we cannot switch to the "platform ratings" as we're on XWiki 6.2.4 and ratings are in platform since 6.4. So, this is what I propose: * release a 1.3.5 version from the contrib code - if I understand correctly how extensions.xwiki.org works, this release will not appear as "most recent" on the application page - if I understand correctly how maven works, this version will not be considered more recent than 8.1 even if released after, because of the version number. * this means that the version 1.3.5 will be available as an upgrade to the users that use the contrib extension (v 1.3.4 or lower), will be available for new install to all users for which the dependencies requirements are satisfied and will not impact the users which use the platform version of the ratings app. Please let me know if I'm wrong in my reasoning. The advantage of this release would be publishing the bugfix work that we've done and making it available to all users of the ratings extension on versions lower than 6.4. Also, for us the advantage would be not having to deal with a code fork and manage a release / snapshot of this forked code separately. Unless somebody -1s this in the very close feature, we will go ahead with the release. Thanks, Anca P.S. There is a larger discussion to have about how to provide bugfixes on older versions of platform applications without upgrading all the wiki, but this should be in another mail or on IRC (e.g. if we discover that indeed these issues affect ratings app, the platform version, and we make fixes for these bugs, how can we provide these fixes to an XWiki 6.4 user?) _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
