2016-08-23 12:36 GMT+02:00 Paul Libbrecht <[email protected]>: > > > Thomas Mortagne wrote: > > It takes the following IMO: > > * it works > > * it does not break any retro compatibility > both are claimed. > There are unit tests. > The only danger of breaking anything is if dom4j does not faithfully > restore the XML source. I believe this can be ignored just as it has > been ignored by the implementation of transformations. > > (probably not enabled by default for example) > No, it is enabled by default. > I could replace the dom4j output by a file copy if no relevant elements > are found. > > Note however, that it operates on elements that were never allowed before. > > Now Guillaume has a point. The issue you will quickly have as soon as > > you start using this is that you HAVE to modify your XAR trough > > filesystem because you can't edit it in XWiki and export it anymore. > > That is if you don't provide any tool to export this kind of XAR > > extension. > I believe this is best practice to insure that the wiki does not insert > you surprise elements such as the author name or the edit comment.
In practice, this is the only manual step. I do a diff of the modifications I have made and I revert all changes that are meaningless. But it's quick & easy using my IDE (IntelliJ). I know some developers here do the same. The only issue is when the XAR format have changed: some fields are not ordered in the same way, and it makes harder to compute the real diff. > Is > this practice not corresponding at all what others are doing? > > Using an XML-diff might be answering Guillaume's point... That's not > completely trivial. > > Paul > _______________________________________________ > devs mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/devs > -- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
